Ping ApplauseLeads when there's a Cherry Pick

[isagoico]

For the past deploy checklists there has been some cherry pick PRs that need QA. When these are CPd to fix a deploy blocker there's no notification (for us at Applause) to test those PRs and verify if the fix was a pass or not.

It would be great and more effective if there's a notification tagging the Applause Leads when there's a CP that needs QA.

[iwiznia]

How would we know if the CP needs QA or not? I can't think of an easy way to automate this really...

[isagoico]

Mmm if the CP is fixing a deploy blocker we should probably retest if the issue is not reproducible so it can be checked off the checklist. Also, I'm almost sure the CPs made recently included some QA steps, let me look for one.

[MelvinBot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

Here's an example of a CP that has QA #4020

Also, forgot to tag you guys before :) Can you give a look at this proposal CC @roryabraham @AndrewGable

[thienlnam]

Seems like we can just use the CP Staging tag that already exists to ping ApplauseLeads for when PRs get merged with this?

[roryabraham]

Seems like we can just use the CP Staging tag that already exists to ping ApplauseLeads for when PRs get merged with this?

Not quite, because PRs can be manually CP'd after-the-fact in the event the author forgot to give the PR the CP Staging label when it was merged. Also, it's more useful to ping them once the CP is completed, rather than when the PR is merged.

So the solution for this should really be implemented in the markPullRequestsAsDeployed GH Action. You can see here is where we determine whether a deployed PR was CP'd or deployed normally. In the event it was CP'd, we could also tag @Expensify/applauseleads in the deploy comment.

[roryabraham]

And to @iwiznia's point, we could skip tagging @Expensify/applauseleads if the PR title includes the string No QA (case insensitive). Worst case scenario, they are tagged and see that there are no QA steps for that PR, which should be NBD.