[HOLD for payment 2024-06-28] [$250] mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.76.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4575560
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Go offline

1. Go to https://staging.new.expensify.com/home
2. Tap on a report
3. Tap plus icon - upload an attachment image

Expected Result:

The image preview should be displayed even when uploading an attachment while offline.

Actual Result:

Uploading an image while offline briefly shows an offline message in the preview

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493126_1716829499362.Screenrecorder-2024-05-27-21-18-51-168.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017a93bd4c637b4a77
• Upwork Job ID: 1798155121003208704
• Last Price Increase: 2024-06-05
• Automatic offers:
• allgandalf | Reviewer | 102625969
• Krishna2323 | Contributor | 102625971

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview

What is the root cause of that problem?

We use AttachmentOfflineIndicator component for local files also and isLoading is initially true.

App/src/components/ImageView/index.tsx

Line 217 in fd322cc

{isLoading && <AttachmentOfflineIndicator />}

App/src/components/ImageView/index.tsx

Line 251 in fd322cc

{isLoading && <AttachmentOfflineIndicator />}

What changes do you think we should make in order to solve the problem?

We can check if the attachment is a local file or not and only show AttachmentOfflineIndicator when the attachment is not a local file. We can also use isPreview prop of AttachmentOfflineIndicator.

const isLocalFile = url.startsWith('blob:') || url.startsWith('file:');

We might also want to do the same in other components which uses AttachmentOfflineIndicator.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017a93bd4c637b4a77