[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Workspace features-User not returned to WS settings after enabling Accounting in more features

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42026

Action Performed:

1. Open the app and log in
2. Create a new workspace
3. Navigate to the workspace settings
4. Open More features
5. Enable Accounting

Expected Result:

User is returned to workspace settings, the Accounting feature is highlighted

Actual Result:

User is not returned to the workspace settings. The Accounting feature is not removed immediately after disabling

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495362_1717004098448.video_2024-05-29_13-34-27.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify / @kadiealexander

Issue Owner

Current Issue Owner: @bfitzexpensify / @kadiealexander

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace features-User not returned to WS settings after enabling Accounting in more features

What is the root cause of that problem?

It's because we are not navigating after enabling policy connections

App/src/libs/actions/Policy/Policy.ts

Lines 3668 to 3669 in ee1196d

	API.write(WRITE_COMMANDS.ENABLE_POLICY_CONNECTIONS, parameters, onyxData);
	}

What changes do you think we should make in order to solve the problem?

We can add after this

App/src/libs/actions/Policy/Policy.ts

Lines 3668 to 3669 in ee1196d

	API.write(WRITE_COMMANDS.ENABLE_POLICY_CONNECTIONS, parameters, onyxData);
	}

    if (enabled && getIsNarrowLayout()) {
        navigateWhenEnableFeature(policyID);
    }

What alternative solutions did you explore? (Optional)

[bfitzexpensify]

@allroundexperts looks like this might have been caused by #42026 - mind checking?

[Nodebrute]

@bfitzexpensify Hey, It's not a regression from this #42026

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.