[HOLD for payment 2024-06-20] Group chat - Member amount is 0 when creating group chat offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-79-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Go to FAB > Start chat
4. Create a group chat with a few users
5. Tap on the chat header

Expected Result:

Members will show the correct number of group members

Actual Result:

Members show 0 when there are some group members

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6501741_1717515811787.zero_mem.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ShridharGoel

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@aldo-expensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - Member amount is 0 when creating group chat offline

What is the root cause of that problem?

There is an extra && isSystemChat in the below condition which causes the condition to be always false when it's a group chat.

App/src/pages/ReportDetailsPage.tsx

Lines 94 to 101 in 1865aa8

	const participants = useMemo(() => {
	if (isGroupChat || isSystemChat) {
	// Filter out the current user from the particpants of the systemChat
	return ReportUtils.getParticipantAccountIDs(report.reportID ?? '').filter((accountID) => accountID !== session?.accountID && isSystemChat);
	}
	return ReportUtils.getVisibleChatMemberAccountIDs(report.reportID ?? '');
	}, [report, session, isGroupChat, isSystemChat]);

What changes do you think we should make in order to solve the problem?

Change it to this:

const participants = useMemo(() => {
    if (isSystemChat) {
        // Filter out the current user from the participants of the systemChat
        return ReportUtils.getParticipantAccountIDs(report.reportID ?? '').filter((accountID) => accountID !== session?.accountID);
    }

    return ReportUtils.getVisibleChatMemberAccountIDs(report.reportID ?? '');
}, [report, session, isSystemChat]);

We don't need the check for isGroupChat, getVisibleChatMemberAccountIDs should be used.

[ShridharGoel]

@aldo-expensify Since this is a blocker, I can open a PR quickly. Can you have a look at the above proposal?

It is caused by #41290.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Member amount is 0 when creating group chat offline

What is the root cause of that problem?

Regression caused by this PR #41290. If it's not a systemChat we are filtering out all the members. The purpose of this change was to filter current user from members list if it's a system chat

App/src/pages/ReportDetailsPage.tsx

Line 97 in 1865aa8

return ReportUtils.getParticipantAccountIDs(report.reportID ?? '').filter((accountID) => accountID !== session?.accountID && isSystemChat);

What changes do you think we should make in order to solve the problem?

This was added to filter out current user from members list. But with this is also removing current user from group's members list too

App/src/pages/ReportDetailsPage.tsx

Line 97 in 1865aa8

return ReportUtils.getParticipantAccountIDs(report.reportID ?? '').filter((accountID) => accountID !== session?.accountID && isSystemChat);

So removing just isSystemChat will not work here. We can do something like this as we don't want to filter current user from member's list

   if (isGroupChat) {
           
            return ReportUtils.getParticipantAccountIDs(report.reportID ?? '');
        }
        if(isSystemChat){
             // Filter out the current user from the particpants of the systemChat
            return ReportUtils.getParticipantAccountIDs(report.reportID ?? '').filter((accountID) => accountID !== session?.accountID)
        }

What alternative solutions did you explore? (Optional)

We don't show members page if it's a system report

App/src/pages/ReportDetailsPage.tsx

Line 154 in 1865aa8

!isSystemChat

We can remover filtering logic here

 const participants = useMemo(() => {
        if (isGroupChat) {
           
            return ReportUtils.getParticipantAccountIDs(report.reportID ?? '');
        }

        return ReportUtils.getVisibleChatMemberAccountIDs(report.reportID ?? '');
    }, [report, session, isGroupChat, isSystemChat]);

[ShridharGoel]

Proposal

Updated to add full function code.

[Nodebrute]

Proposal Updated

Alternative solution added

[ShridharGoel]

Proposal

Updated to add few more details.