[HOLD for payment 2024-08-09] [$250] Search - List still shows receipt when removed, and receipt reappears when returning online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM
3. Submit an expense with a receipt
4. Go to Search and open the transaction from Step 3
5. Go offline
6. Click on the receipt and delete it
7. Dismiss the RHP
8. Note that the expense in the list still has the receipt and not removed
9. Go online
10. Open the transaction from Search again
11. Note that the removed receipt changes to green thumbnail and can be viewed when opened

Expected Result:

In Step 8, after removing receipt offline, the expense in the list will not show the receipt
In Step 11, when returning online, the deleted receipt will not appear again

Actual Result:

In Step 8, after removing receipt offline, the expense in the list still shows the receipt
In Step 11, when returning online, the deleted receipt appears as a green thumbnail and can be viewed when opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240618_203314.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01306ca9167fa65ee4
• Upwork Job ID: 1805674432579051426
• Last Price Increase: 2024-06-25
• Automatic offers:
• nkdengineer | Contributor | 102955586

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 8, after removing receipt offline, the expense in the list still shows the receipt
In Step 11, when returning online, the deleted receipt appears as a green thumbnail and can be viewed when opened

What is the root cause of that problem?

When we delete the receipt, we update the receipt field of transaction as an empty object and we use the set method to update the transaction in Onyx so it works fine.

App/src/libs/actions/IOU.ts

Lines 6573 to 6579 in 7561439

	const newTransaction = transaction ? {...transaction, filename: '', receipt: {}} : null;
	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: newTransaction,

But when we update the snapshot data we use merge method here and then the receipt data isn't updated correctly in this case.

What changes do you think we should make in order to solve the problem?

When we delete the receipt here we can update the receipt as null here or we can update to the object with source as empty string.

App/src/libs/actions/IOU.ts

Line 6573 in 7561439

const newTransaction = transaction ? {...transaction, filename: '', receipt: {}} : null;

Another problem here is if we create a request without receipt and then add the receipt to the request, the snapshot is also not updated correctly because we only pick the field that exist in the snapshot data here. To fix this I think when BE return the snapshot data of transaction we can return receipt field as an empty object.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[laurenreidexpensify]

@anmurali handing over for my parental leave clear out. Haven't reviewed this yet, so your call on whether you want to push it forward or close out if not worth a fix. Thanks!

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?