[HOLD for payment 2021-09-17] No error shown on Group Creation with Chronos

[mananjadhav]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB
2. Click "New Group"
3. Add Chronos as the member and click on Create Group
4. No feedback/error message

Expected Result:

1. Chronos shouldn't be visible in the Group list
2. Or show an error when the server sends this 401 Chronos is not permitted to participate in group chats

Actual Result:

chronos-group-participant.mp4

Workaround:

Don't choose Chronos while creating a new Group

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mananjadhav]

Proposal

Don't show Chronos while adding to New Group

1. getNewChatOptions defined in OptionsListUtils.js is being used to get participants in New group. It has a flag to ignoreConceirgeEmails and we can extend it to ignore Chronos email too. Because concerige is allowed in the group chat the config param would look like

function getNewChatOptions( reports, personalDetails, searchValue = '', excludeConcierge, excludeChronos, betas) {

or

function getNewChatOptions( reports, personalDetails, searchValue = '', { excludeConcierge: false, excludeChronos:true }, betas) {

3. Accordingly update getOptions, where we can just add another flag, excludeChronos = false and add the following check

   if (excludeChronos) {
   loginOptionsToExclude.push({login: CONST.EMAIL.CHRONOS});
   }

4. Update references so that Chronos is not visible in the partiicpant search list.

API Error message

In addition to handling on the frontend, I feel we should also handle and show API error on the frontend.

At present there's no catch block and hence API errors are not caught.

In libs/actions/Report.js

fetchOrCreateChatReport(participants, shouldNavigate = true)

	...

	return API.CreateChatReport({

	}).then(() => {
		// Existing function
	}).catch(err => {
	let errorMessage = 
		switch(err.satatusCode) {
			mesage = .....
		}
		return throw new Error(translate(message))
	});
}

Then in NewGrouPage

	fetchOrCreateChatReport(...).then(...).catch(err => {
		Growl(err.message) // Error message to com here

	})

[MelvinBot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.