[HOLD for payment + bonus Aug 16] Translation Missing for Edit Message buttons

[mananjadhav]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Upwork post: https://www.upwork.com/jobs/~01141d41100982c438

---

Action Performed:

1. Go to Sidebar click on Preference
2. Change the language to Spanish
3. Come back to Chat Messages and right-click to Edit Comment
4. You'll see the button texts still shows "Cancel" and "Save Changes

Expected Result:

Should show the button texts in Spanish

Actual Result:

Shows the button texts in English only

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mananjadhav]

Proposal

Basically the button texts are hardcoded with english content. Need to pick these from translations.

In ReportActionItemMessageEdit.js,

// Change button texts with translate function

<Button
    style={[styles.mr2]}
    onPress={this.deleteDraft}
    text={this.props.translate('common.cancel')}
/>
<Button
    success
    style={[styles.mr2]}
    onPress={this.publishDraft}
    text={this.props.translate('common.saveChanges')}
/>


// Add references for localization


export default compose(    
	withLocalize, withWindowDimensions
)(ReportActionItemMessageEdit);

and add translation for saveChanges key in en.js and es.js

en: 
	common: {
		saveChanges: 'Save Changes'
	}

es:
	common: {
		saveChanges: 'Guardar cambios'
	}

[lschurr]

Is this different from this one? #4218

[mananjadhav]

@lschurr Yes. This one handles the button texts - Edit and Cancel (highlighted in red rectangle in the screenshot above).

#4218 deals with the timestamp itself not showing up when language is switched. (Line below the red rectangle).

[MelvinBot]

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.