[HOLD for payment 2024-08-07] [$250] Dupe detect - Removed expense during review offline is accessible & fields open not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two same expenses (same amount. date and merchant)
4. Go to any transaction thread
5. Go offline
6. Click Review duplicates
7. Click Keep this one (any)
8. On confirmation page, click Confirm
9. Return to the expense report
10. Click on the expense preview with skeleton

Expected Result:

The expense which is removed during duplicate review offline should be crossed out and inaccessible

Actual Result:

The expense which is removed during duplicate review offline is accessible and all the fields in the transaction thread lead to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549542_1721659868909.bandicam_2024-07-22_22-46-56-762.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011cf834f88beec2ec
• Upwork Job ID: 1815779453230360541
• Last Price Increase: 2024-07-23

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MariaHCD]

@lanitochka17 just to confirm, this bug is not reproducible on production? Do you have a recording of the behavior on production?

[roryabraham]

was able to reproduce this one locally

[roryabraham]

The problem here is that in IOU.mergeDuplicates we need to also optimistically delete the IOU reportActions for the transactions marked as duplicates

[roryabraham]

A broad set of changes will be required here:

• update the lastMessageText and lastMessageHTML for the policyExpenseChat
• set message.deleted for the IOU action on the expense report
• update the message[0].text and message[0].html for the REPORT_PREVIEW action in the policyExpenseChat
• update the MoneyRequestAction component to return null if the action is deleted

[roryabraham]

WIP PR to fix this issue: #45961

[francoisl]

Any luck with that PR @roryabraham?