[HOLD for payment] [$250] Admins room members shows 2 members but members list only has one person

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.15-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722451867724679

Action Performed:

1. Sign up for account
2. Choose "manage my team"
3. Click on the "meet your setup specialist" task
4. Click on the "admins room" link

Expected Result:

Both admin and chat specialist displayed in admin room

Actual Result:

Only admin is displayed in member list but the member count is displayed as 2

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.403.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0158f19a1453ec7c77
• Upwork Job ID: 1819232195007431581
• Last Price Increase: 2024-08-02
• Automatic offers:
• dominictb | Contributor | 103414279

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only admin is displayed in member list but the member count is displayed as 2

What is the root cause of that problem?

We do not filter out the accountID that is not available in personalDetails data:

App/src/pages/ReportDetailsPage.tsx

Lines 146 to 149 in 157afbf

	const activeChatMembers = participants.flatMap((accountID) => {
	const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString());
	return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : [];
	});

like we did in

App/src/pages/ReportParticipantsPage.tsx

Lines 71 to 73 in 157afbf

	const details = personalDetails?.[accountID];
	if (!details) {
	Log.hmmm(`[ReportParticipantsPage] no personal details found for Group chat member with accountID: ${accountID}`);

What changes do you think we should make in order to solve the problem?

We should check if the accountID is available in personalDetails data or not. If not, remove from activeChatMembers

App/src/pages/ReportDetailsPage.tsx

Lines 146 to 149 in 157afbf

	const activeChatMembers = participants.flatMap((accountID) => {
	const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString());
	return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : [];
	});

We also can filter out in

App/src/pages/ReportDetailsPage.tsx

Lines 139 to 142 in 157afbf

	const participants = useMemo(() => {
	const shouldExcludeHiddenParticipants = !isGroupChat && !isSystemChat;
	return ReportUtils.getParticipantsAccountIDsForDisplay(report, shouldExcludeHiddenParticipants);
	}, [report, isGroupChat, isSystemChat]);

What alternative solutions did you explore? (Optional)

[github-actions]

true

[dominictb]

Proposal updated

[github-actions]

true

[VictoriaExpensify]

Recreated issue:

Agree we should fix this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0158f19a1453ec7c77