[HOLD for Payment 2024-09-09][$250] Wrong parsing when single backticks used in 2 separate places

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722625457122619

Action Performed:

1. Open any report
2. Send the string "it uses ; separated fields because the line number column could have : in them"

Expected Result:

it uses;separated fields because the line number column could have:in them

Actual Result:

it uses ; separated fields because the line number column could have : in them

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014560c8f3601ebcb2
• Upwork Job ID: 1823820445986093493
• Last Price Increase: 2024-08-14
• Automatic offers:
• ikevin127 | Reviewer | 103588545
• tsa321 | Contributor | 103588546

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[tsa321]

Edited by proposal-police: This proposal was edited at 2024-08-07 07:14:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong parsing when single backticks with a semicolon character used in 2 separate places

What is the root cause of that problem?

The regex rule for inlineCodeBlock:

https://github.com/Expensify/expensify-common/blob/fea340b9d71bf2415ed1e8745ac60bafb4fc0cfa/lib/ExpensiMark.ts#L193

because of the square bracket in (?![`]) it search for optional character inside the square bracket instead of the back tick character. If inside the code is one of the character in this case ; the result will be incorrect.

What changes do you think we should make in order to solve the problem?

We could modify the regex to be:

 regex: /(\B|_|)&#x60;((?:&#x60;)*)(?!&#x60;)(.*?\S+?.*?)(?<!&#x60;)((?:&#x60;)*)(&#x60;)(\B|_|)(?!&#x60;|[^<]*<\/pre>|[^<]*<\/video>)/gm,
 replacement: '$1<code>$2$3$4</code>$6',

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Hmm @thienlnam should we resolve this issue as part of on-going maintenance of our markdown library?

[thienlnam]

We've been making some of these external - cc @BartoszGrajdek Looks like this one can also be external right? Or would you like to take it

[BartoszGrajdek]

Looks like this one can also be external right?

Yes, this is something External contributors can definitely work on 🙌🏻

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014560c8f3601ebcb2