Skip to content

[CRITICAL] [Advanced Approval Workflows] Removing a workspace approval by setting submitsTo to an empty string doesn't work #46984

@tgolen

Description

@tgolen

Problem

The frontend of App is removing a workspace approval by setting submitsTo to an empty string for all employees. The backend does not allow for submitsTo to be an empty string, so the backend throws a parameter validation error.

Why this is important to solve?

The frontend and the backend need to both be aligned with how removing an approver works so that the logic is consistent.

Solution

Update the backend to allow an empty submitsTo value for SetWorkspaceApproval, which should trigger this logic to set the submitsTo to the default approver on the policy.

cc @blazejkustra

Metadata

Metadata

Assignees

Labels

DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions