[$250] Scan - "Delete" and "Replace" options are displayed for an admin which causes an error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4845247
Email or phone of affected tester (no customers): htad26+foiotfy@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite
Create a workspace and invite an employee to the workspace
Login as an owner and employee

1. As the employee navigate to the workspace chat and click on the + icon > Submit expense > Scan
2. Upload a receipt and finish the flow
3. After the expense is created navigate to the tab where you are logged in as the admin/owner
4. Click on the receipt thumbnail
5. Here notice that the "Delete" and "Replace" options are displayed
6. Click on "Replace" > Choose another receipt > Upload > Notice that an error is thrown
7. Click on "Delete" > Confirm > Notice that an error is thrown

Expected Result:

The workspace admin cannot edit the receipt file so there should not be "Delete" and "Replace" options

Actual Result:

"Delete" and "Replace" options are displayed and when performing these actions, an error is thrown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6569955_1723471856291.2024-08-12_16_51_26.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a08abb02f6c6658f
• Upwork Job ID: 1823152253036105130
• Last Price Increase: 2024-08-13

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Delete" and "Replace" options are displayed for an admin which causes an error

What is the root cause of that problem?

We are allowing Admin to edit receipt here

App/src/libs/ReportUtils.ts

Line 2934 in 7481b6e

(isAdmin || isManager || isRequestor)

What changes do you think we should make in order to solve the problem?

We can remove isAdmin from here

App/src/libs/ReportUtils.ts

Line 2934 in 7481b6e

(isAdmin || isManager || isRequestor)

What alternative solutions did you explore? (Optional)

In case we only want to allow requestor to delete and replace the reciept than we can remove both options isAdmin and isManager

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a08abb02f6c6658f