Pressing 'Enter' key in Password field submits form when submit button is disabled

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to /bank-account/company. (Web)
2. Click the Password field at the end
3. Press Enter key

Expected Result:

Nothing should have happened since the 'Save & Continue' button is disabled

Actual Result:

Submit action was triggered even if the 'Save & Continue' button was disabled. If the checkbox at the end is the only thing left to be filled, there isn't any red mark indicating that this is what is missing.

Screen.Recording.2021-08-18.at.12.55.52.PM.mov

Workaround:

Doesn't block the flow, users can use the app normally

Platform:

Where is this issue occurring?

• Web
• Desktop App
• Mobile Web

Not sure about these:

• iOS
• Android

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @trjExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[trjExpensify]

Oh yeah, this is weird. I'm also a tad confused because in your video you haven't filled in the other fields and we don't provide feedback that those need to be filled out too. Can they actually be left blank, @MitchExpensify @kevinksullivan what's the intended outcome here?

[aldo-expensify]

Oh yeah, this is weird. I'm also a tad confused because in your video you haven't filled in the other fields and we don't provide feedback that those need to be filled out too. Can they actually be left blank, @MitchExpensify @kevinksullivan what's the intended outcome here?

The current implementation puts an error message on a single field (first or last it finds?, not sure), even if all of them have errors. If I fixed the error with the password, another field would get the error message. Maybe we should try to show all error messages at once?

Related GH issues:

https://github.com/Expensify/Expensify/issues/171620
#4730

[MitchExpensify]

You shouldn't be able to continue with any empty fields.

I think it makes sense to highlight all fields that are in error.

[kevinksullivan]

Hm yeah every field is required, and we should be highlighting every field that has an error when someone tries to move forward. @aldo-expensify does your PR also fix this issue and show the error message for ALL field errors, or should we create a separate one?

[aldo-expensify]

That PR doesn't address the part of showing all field errors. I suggest creating a new issue and then I can work on a PR against that

[kevinksullivan]

Separate issue for not outlining all errors ^

[aldo-expensify]

Separate issue for not outlining all errors ^

thanks @kevinksullivan