[$250] Address - Address without state can be saved

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.21-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Profile > Address.
3. Select a US address.
4. Click Country and select United Kingdom.
5. Enter anything in State field and click Save (ignore the incorrect zip code).
6. Click Country and select United States.
7. Without selecting State, click Save.

Expected Result:

App should not be able to save address without state.

Actual Result:

The address without state can be saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6575237_1723986353394.20240818_210053.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0142ffeec763fcd562
• Upwork Job ID: 1828601412039191657
• Last Price Increase: 2024-08-28
• Automatic offers:
• abzokhattab | Contributor | 103745348

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-08-18 22:28:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Address without state can be saved

What is the root cause of that problem?

The defaultValue prop is used in the state component of the AddressForm instead of value. As a result, when the value of the country changes, the state resets to "" here, but this change isn't reflected in the UI because defaultValue only sets the initial value.

App/src/components/AddressForm.tsx

Lines 191 to 199 in 5a2602c

	<View style={styles.mhn5}>
	<InputWrapper
	InputComponent={StateSelector}
	inputID={INPUT_IDS.STATE}
	defaultValue={state}
	onValueChange={onAddressChanged}
	shouldSaveDraft={shouldSaveDraft}
	/>
	</View>

What changes do you think we should make in order to solve the problem?

We should use value instead of defaultValue in the StatePicker component, and adjust other components if necessary.

POC

Screen.Recording.2024-08-19.at.12.21.51.AM.mov

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Address without state can still be saved.

What is the root cause of that problem?

We don't use defaultValue when we validate the form

What changes do you think we should make in order to solve the problem?

We can add shouldUseDefaultValue here:

App/src/components/AddressForm.tsx

Lines 192 to 198 in 62722e8

	<InputWrapper
	InputComponent={StateSelector}
	inputID={INPUT_IDS.STATE}
	defaultValue={state}
	onValueChange={onAddressChanged}
	shouldSaveDraft={shouldSaveDraft}
	/>

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@anmurali Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0142ffeec763fcd562