Failed CP workflow does not ping in #announce

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Attempt to CP an issue instead of a PR 🤦

Expected Result:

When the workflow inevitably fails, it should announce the failure in the #announce slack room.

Actual Result:

Failure is not announced.

Workaround:

n/a

Platform:

GitHub only.

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

[roryabraham]

Example: https://github.com/Expensify/App/actions/runs/1159658147

[bondydaa]

Hmm I'm not sure I agree this should be in #announce, I think #deployer makes more sense since it would have been requested to be CP'd in #deployer and more people are in that room and actively working on things than in #announce. I view #announce more as a "read-only" type channel and is more a record/audit area and find the @here pings there to be pretty distracting and annoying.

[bondydaa]

oh didn't notice we aren't @here in the solution so less concern from me then... now I'm not sure where I land on the best room for this post 🤔

I'm not exactly following what is going on in this link - https://github.com/Expensify/App/actions/runs/1159658147

Do App pull requests automatically get CP'd? no need for a deployer to do something?

[roryabraham]

Do App pull requests automatically get CP'd? no need for a deployer to do something?

They get automatically CP'd if they are merged with the CP Staging label, but they can be manually CP'd after-the-fact too.

https://stackoverflow.com/c/expensify/questions/10366

[bondydaa]

ah interesting.

So we have a team already https://github.com/orgs/Expensify/teams/expensify-cash-deployers.

#announce is probably fine for this then. Should we also tag the https://github.com/orgs/Expensify/teams/expensify-cash-deployers team during a failure?

[bondydaa]

oh god i'm eating stupid pills today 🤦 that's a github team not a slack team

[roryabraham]

I think moving this to #deployer and using @here is fine – but we just announce all of our other workflow failures in #announce currently. I don't really care either way.

So we have a team already https://github.com/orgs/Expensify/teams/expensify-cash-deployers.

Funny enough, that's a soon-to-be-deprecated team. It's being swallowed by mobile-deployers (aka NewDot deployers nowadays). So we could tag the mobile deployers slack team instead of @here.

[bondydaa]

coolio so let's tag the mobile-deployers on slack as well then? I think either deployer or announce is fine as long.