Skip to content

[Advanced Approval Workflows] Cleanup the logic responsible for building policy.employeeList #48341

@blazejkustra

Description

@blazejkustra

Coming from this project, we have this follow-up polish issue – we need to refactor the logic that is responsible for building the data on the frontend that is later sent to update policy.employeeList.

Having following policy:

Admin: A
Member: 1
Member: 2

When advanced approvals is turned on, the employee list looks like this:

A submitsTo A
1 submitsTo A
2 submitsTo A

If I edit that workflow to set 2 as the additional approver, the frontend sends this payload:

A submitsTo A forwardsTo 2
1 submitsTo A
2 submitsTo A

That's mostly OK, but since submitsTo isn't changing for anyone, the payload could be more simple with just:

A forwardsTo 2
Issue OwnerCurrent Issue Owner: @anmurali

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.MonthlyKSv2ReviewingHas a PR in review

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions