[Awaiting Payment] [$250] Multi tags - Main tag shows "Required" status when all the subtags are disabled

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-4
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validation PR: #48381
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Click on any main tag.
4. Enable "Required" switch.
5. Select all the subtags > Disable.
6. Disable all the subtags.
7. Return to main tag page.

Expected Result:

The main tag will not show "Required" status when all the subtags are disabled.

Actual Result:

The main tag shows "Required" status when all the subtags are disabled.
The "Required" status is gone after reopening the subtag list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594733_1725578358405.1725577741534_Screen_Recording_20240906_070850_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833824644157847399
• Upwork Job ID: 1833824644157847399
• Last Price Increase: 2024-09-11
• Automatic offers:
• ikevin127 | Reviewer | 103912305

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-09-06 10:27:23 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multi tags - Main tag shows "Required" status when all the subtags are disabled

What is the root cause of that problem?

We are not checking if it has one enabled tag when displaying required tag here

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 100 in 2ee0bfc

required: policyTagList.required,

It is gone after opening the tag because we set required to false here

App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

Lines 235 to 236 in 2ee0bfc

	if (!!currentPolicyTag?.required && !Object.values(currentPolicyTag?.tags ?? {}).some((tag) => tag.enabled)) {
	Tag.setPolicyTagsRequired(policyID, false, route.params.orderWeight);

What changes do you think we should make in order to solve the problem?

We should add && OptionsListUtils.hasEnabledOptions(tags) to check if it has an enabled option

                required: policyTagList.required&&OptionsListUtils.hasEnabledOptions(policyTagList.tags),

In WorkspaceViewTagsPage we can apply the same condition to switch of the required toggle or we can also disable the toggle when there are no enabled tags.

What alternative solutions did you explore? (Optional)

We can also setPolicyTagsRequired to false in WorkspaceTagsPage as we did here.
for isMultiLevelTags case we can iterate on policyTagsLists array and setPolicyTagsRequired to false for every muiti-level tag where required is true and all sub tags are disabled.

[garrettmknight]

Checking for a regression on the linked PR

[Shahidullah-Muffakir]

@garrettmknight

To hide the "Required" label when all tags are disabled, we should implement a similar check to what we applied for the Required toggle. The current check only verifies if the policyTagList is required, but it doesn't account for the scenario where all subtags are disabled

in this :

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 103 in 7dc2515

labelText={policyTagList.required ? translate('common.required') : undefined}

We can update the logic as follows:
labelText={policyTagList.required && !!Object.values(policyTagList?.tags ?? {}).some((tag) => tag.enabled) ? translate('common.required') : undefined}
This way, the label will only appear if the main tag is required and at least one subtag is enabled.

Additionally, I'm not sure if this issue is a regression—it seems more like a separate bug that was overlooked in the previous implementation.

[Shahidullah-Muffakir]

@garrettmknight I’ve opened a PR #48738 to address this issue. It’s now ready for review. Thank you.

[ikevin127]

• ⛔ I'm currently blocked from testing and completing the reviewer checklist by deploy blocker issue Multi tags - App freezes when clicking checkbox in subtag list #48675, will await until the fix is merged in order to resume testing!