[PAID] [$250] Room - After rejoining room, notification settings changed to immediately

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Via fab, create a room
3. Tap header -- settings
4. Note notifications is set "daily"
5. Tap leave and now tap header -- settings
6. Now note notifications field missing
7. Now send a message and join the room
8. Tap header--settings

Expected Result:

After rejoining room, notification settings must not change to immediately.

Actual Result:

After rejoining room, notification settings changed to immediately.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6594781_1725582608988.on.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833657980074790757
• Upwork Job ID: 1833657980074790757
• Last Price Increase: 2024-10-02
• Automatic offers:
• shubham1206agra | Contributor | 104297840

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2023-10-03T13:22:17Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After rejoining room, notification settings changed to immediately

What is the root cause of that problem?

When we leave room we set the notification preference to "hidden" and when we join room by adding comment we set the notification preference to "always"

What changes do you think we should make in order to solve the problem?

We should update this to daily because when we create room the notification preference is daily CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY

App/src/libs/actions/Report.ts

Line 495 in 812fc31

optimisticReport.notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS;

We need to change this in joinroom too. We can also fix this in other places.

What alternative solutions did you explore? (Optional)

[dominictb]

Edited by proposal-police: This proposal was edited at {current_timestamp}.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• After rejoining room, notification settings changed to immediately.

What is the root cause of that problem?

• In here:
  

  App/src/libs/actions/Report.ts

  Line 495 in 812fc31

  optimisticReport.notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS;

  
  and here:
  

  App/src/libs/actions/Report.ts

  Line 555 in 812fc31

  notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,

  
  we always set the notificationPreference to always.

What changes do you think we should make in order to solve the problem?

• We should update:
  

  App/src/libs/actions/Report.ts

  Line 495 in 812fc31

  optimisticReport.notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS;

  
  to:

        optimisticReport.notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS;
        if (ReportUtils.isUserCreatedPolicyRoom(report)) {
            optimisticReport.notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY;
        }

and the same should be applied to:

App/src/libs/actions/Report.ts

Line 555 in 812fc31

notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,

• Additionally:
  

  App/src/pages/workspace/WorkspaceNewRoomPage.tsx

  Line 120 in 812fc31

  CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,

  
  should be CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY

What alternative solutions did you explore? (Optional)

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833657980074790757

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)