[HOLD for payment 2024-11-14] [$250] [Held requests] Not here page for held expense when partially pay the report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): gocemate+a2160@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. User A goes to chat with User B
2. User A submits two expenses
3. User B put on hold first expense
4. User B partially pay the report
5. User B navigates to unpaid expense that is put on hold

Expected Result:

Held expense should open and show the transaction details

Actual Result:

Not here page appear when open unpaid held expense. On LHN this chat is displayed as Unavailable workspace owes - currency, -1 amount

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6604173_1726390623812.Recording__3945.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838873865299371336
• Upwork Job ID: 1838873865299371336
• Last Price Increase: 2024-10-09
• Automatic offers:
• hoangzinh | Reviewer | 104402955
• mkzie2 | Contributor | 104920263

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[garrettmknight]

@robertjchen are you aware of this behavior?

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-11 14:03:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page appear when open unpaid held expense. On LHN this chat is displayed as Unavailable workspace owes - currency, -1 amount

What is the root cause of that problem?

If we pay the report partially, we build the hold report Onyx data by using getReportFromHoldRequestsOnyxData function

App/src/libs/actions/IOU.ts

Line 6857 in 14b99ca

const holdReportOnyxData = getReportFromHoldRequestsOnyxData(chatReport, iouReport, recipient);

Let's see optimisticExpenseReport here, we always build an expense report even if we're paying in an iou report. That causes LHN to display the wrong message

App/src/libs/actions/IOU.ts

Line 6475 in abdfb72

const optimisticExpenseReport = ReportUtils.buildOptimisticExpenseReport(

Here is the logic we used to get the message text of the report preview action. We get the iou report of the report preview and use getReportPreviewMessage to get the message

App/src/libs/OptionsListUtils.ts

Lines 676 to 688 in 12e41b1

	} else if (ReportActionUtils.isReportPreviewAction(lastReportAction)) {
	const iouReport = ReportUtils.getReportOrDraftReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
	const lastIOUMoneyReportAction = allSortedReportActions[iouReport?.reportID ?? '-1']?.find(
	(reportAction, key): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> =>
	ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	ReportActionUtils.isMoneyRequestAction(reportAction),
	);
	const reportPreviewMessage = ReportUtils.getReportPreviewMessage(
	!isEmptyObject(iouReport) ? iouReport : null,
	lastIOUMoneyReportAction,
	true,
	ReportUtils.isChatReport(report),

And the payerName is wrong in this case. It displays as policyName because iouReport is an expense report as the reason above

App/src/libs/ReportUtils.ts

Line 3449 in 12e41b1

const payerName = isExpenseReport(report) ? policyName : getDisplayNameForParticipant(report.managerID, !isPreviewMessageForParentChatReport);

What changes do you think we should make in order to solve the problem?

If the iouReport is an iou report we should use buildOptimisticIOUReport function to create an optimistic iou report and we also need to introduce new param in buildOptimisticIOUReport to update the parentReportActionID if the new iou report as we do for buildOptimisticExpenseReport

const optimisticExpenseReport = ReportUtils.isExpenseReport(iouReport)
    ? ReportUtils.buildOptimisticExpenseReport(
          chatReport.reportID,
          chatReport.policyID ?? iouReport.policyID ?? '',
          recipient.accountID ?? 1,
          holdTransactions.reduce((acc, transaction) => acc + transaction.amount, 0) * (ReportUtils.isIOUReport(iouReport) ? 1 : -1),
          getCurrency(firstHoldTransaction),
          false,
          newParentReportActionID,
      )
    : ReportUtils.buildOptimisticIOUReport(
          iouReport.ownerAccountID ?? -1,
          iouReport.managerID ?? -1,
          holdTransactions.reduce((acc, transaction) => acc + transaction.amount, 0) * (ReportUtils.isIOUReport(iouReport) ? 1 : -1),
          chatReport.reportID,
          getCurrency(firstHoldTransaction),
          false,
          newParentReportActionID,
      );

App/src/libs/actions/IOU.ts

Line 6475 in abdfb72

const optimisticExpenseReport = ReportUtils.buildOptimisticExpenseReport(

What alternative solutions did you explore? (Optional)

[garrettmknight]

@robertjchen assigning you to confirm whether we're aware and fixing this somewhere else before adding External.

[robertjchen]

Thanks, let me evaluate!

[robertjchen]

Ok, yes- we're already working on the fix for this here: #46370 Consolidating there

[mkzie2]

On LHN this chat is displayed as Unavailable workspace owes - currency, -1 amount

@robertjchen We also have another bug here and it's a front-end bug.

[robertjchen]

We can revisit this issue after the other fix goes out- it's only happening because the backend is handling the whole process incorrectly.