Puller Bear is not assigning the correct CME when PR is ready for review

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a PR with a linked issue
2. Set it to ready for review
3. Check the puller bear assignment

Expected Result:

Puller bear should assign the same CME that reviewed the proposals

Actual Result:

Puller bear is not assigning the correct CME.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Github

Version Number:

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Example PR: #4801

Extra information from @roryabraham:

To be clear, I think this is working for when new PRs are created (assuming they correctly tag the linked issue), but I think it might not be working when a draft PR is marked as ready-for-review and converted into a "real" PR

@Beamanator was working on these issues:
https://github.com/Expensify/Expensify/issues/173915
https://github.com/Expensify/Expensify/issues/162941

Expensify/Expensify Issue URL:

View all open jobs on GitHub

---

From @roryabraham https://expensify.slack.com/archives/C01GTK53T8Q/p1630360934157300

When a draft PR is marked as ready-for-review, PullerBear does not correctly tag the CME that reviewed proposals on the linked issue. Example: #4801

[MelvinBot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Jag96]

Assigning @Beamanator per slack thread

[MelvinBot]

@Beamanator Eep! 4 days overdue now. Issues have feelings too...

[Beamanator]

It looks like the GitHub webhook event pull_request, with action ready_for_review is sent when a draft PR is marked "Ready for review". I think we have two methods of attack:

1. This event can re-request PullerBear as a reviewer, which will try again to find a CME on a related issue. If a linked issue isn't found or if we can't find a CME on a linked issue, a new Engineer will be requested
   • This could be "non-ideal" since someone will always be assigned by PullerBear when the PR is created (I don't believe it's possible to create a PR in a draft state)
2. The event will trigger attempting to find a CME reviewer (reusing most of the PullerBear::getCashReviewerlogic) but will not add a new Engineer if a CME isn't found

[Beamanator]

Changing to Weekly since we are correctly assigning CMEs, this issue is just to "try again" when PRs are moved from draft -> ready for review