[HOLD for payment 2024-11-11] [$750] Netsuite - App navigates to the first flow when refreshing the page while adding custom list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+shsb22tet1122@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to new dot with any account
2. Create a new workspace > Enable "Accounting" in the "More features" page
3. Navigate to "Accounting" > Connect to NetSuite and upgrade the workspace to Control > Enter credentials and finish
4. After the connection syncs go to Import > Custom Lists > Add custom list
5. Click on "Name" and select any of the options > Next > Type any ID name > Next
6. Before making any selection refresh the page

Expected Result:

App stays in the current flow ("How should this custom list be displayed in Expensify?")

Actual Result:

App navigates to the first step of the flow ("Choose a custom list" step)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6620920_1727773245095.2024-10-01_11_43_59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021842185001478860112
• Upwork Job ID: 1842185001478860112
• Last Price Increase: 2024-11-12
• Automatic offers:
• rayane-djouah | Reviewer | 104455519
• allgandalf | Contributor | 104455521

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021842185001478860112

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Form navigates to first step on refresh

What is the root cause of that problem?

There are actually 2 bug in the flow:

• We do not save the current step anywhere in the flow.
  And we always default to the first step of the flow, that is why on refresh we go to the first step:

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomListPage.tsx

Line 155 in 99f280b

startStepIndex={CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_LISTS.CUSTOM_LIST_PICKER}

• We also do not save the draft values in the flow.

So even if we fix 1, there would be a regression that values won't be saved once refreshed. So we need to fix both the bugs here.

What changes do you think we should make in order to solve the problem?

Like the refactor we did in :

• Refactor on missing details flow #49452

We need to refactor the full form to save draft values of the form as well as save the current state of the form (sub-step) using the util getInitialSubstep. We would also need to refactor NetSuiteImportAddCustomSegmentPage as both use the same substeps. and also update any similar places where this bug exists

Note

The scope of work is vast as this would be full form refactor i.e. adding draft states to Onyx, adding draft values to FORM input of both NetSuiteImportAddCustomSegmentPage and NetSuiteImportAddCustomListPage, creating new utils, changing the form structure completely, creating related types files.
So i think that for this issue a fair compensation would be $750 considering the amount of work involved

What alternative solutions did you explore? (Optional)