[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Android - Search - Keyboard does not auto open in Search modal

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Open a report.
3. Tap Search icon.

Expected Result:

Keyboard will auto open.

Actual Result:

Keyboard does not auto open.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6637494_1729158638593.1729158562598_Screen_Recording_20241017_174902_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846960678624915682
• Upwork Job ID: 1846960678624915682
• Last Price Increase: 2024-10-17
• Automatic offers:
• abzokhattab | Contributor | 104471055

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-10-17 18:17:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Keyboard does not auto open in Search modal

What is the root cause of that problem?

keyboard doesnt open up because we dont use the useAutoFocusInput inside the SearchRouterInput component like we do in other textInput fields and the autoFocus doesn't work well on android with modals

What changes do you think we should make in order to solve the problem?

we should assign the ref to the inputCallbackRef value of the useAutoFocusInput hook:

    const {inputCallbackRef } = useAutoFocusInput();

then use it in the TextInput here:

                        ref={inputCallbackRef}

then we could remove the autoFocus as its now handled by the useAutoFocusInput

What alternative solutions did you explore? (Optional)

optionally we can delay the focus so that the input field focuses correctly by adding shouldDelayFocus

[rayane-d]

cc @289Adam289 @Kicu @SzymczakJ @luacmartins