Workspace - Clicking Manage cards takes user to 404 page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log in with expensifail account
3. Go to any Workspace
4. Click on Manage Cards

Expected Result:

Clicking Manage Card button under Expensify Card is leading for the expensify.com

Actual Result:

Clicking on Manage Card button under Expensify Card is leading for 404 error

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.94-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5225557_Recording__326.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ctkochan22]

Just looking at this now, not sure where this is caused yet. But its strange that the URL is this:

And this is the only pr where we may have changed where we re-direct to? The strange bit in the middle /v/ASDF.../

https://github.com/Expensify/App/pull/4789/files#diff-7ba339cca3eda747a4a803353b2b9ec61d991ae1d3d52ee4726aa0d659308e1aR53

[roryabraham]

@cead22 Do you have any insights as to what may have gone wrong here? This is the last deploy blocker for New Expensify atm.

[ctkochan22]

I think its this PR: #4789

1. Manage card button is here -

   App/src/pages/workspace/WorkspaceCardPage.js

   Line 96 in 1803120

   buttonText = translate('workspace.card.manageCards');

2. Runs openSignedInLink() here -

   App/src/pages/workspace/WorkspaceCardPage.js

   Line 107 in 1803120

   openSignedInLink(CONST.MANAGE_CARDS_URL);

3. And in this PR, we add this to the validate URL which might have fixed the original issue, but breaks this flow - https://github.com/Expensify/App/pull/4789/files#diff-7ba339cca3eda747a4a803353b2b9ec61d991ae1d3d52ee4726aa0d659308e1aR53

[ctkochan22]

@tgolen as the reviewer can you buddy check me here?

[roryabraham]

Is the problem with the URL just that it's missing ? between the validateCode and exitTo?

[tgolen]

I think that's it, Rory. Yep! Looks like that was a bug introduced when the logic was moved out of ROUTES.js

[ctkochan22]

ahh yep that looks like its it. So should we just fix it then instead?

[ctkochan22]

Looks like we were missing the / originally: https://github.com/Expensify/App/pull/4789/files#diff-fed84caebc7e71b17fe9ac17cd04c5ec5aa8ce8a9f2ddc2ad33eb77253560a2eL91