[HOLD for payment 2024-11-18] [$250] Workspace - WS chat is created for invalid phone number

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.52-5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): gibethlehem@gmail.com
**Issue reported by:**Applause Internal Team

Action Performed:

1. Login to an account
2. create a WS
3. Invite a user with invalid Phone number(Invalid Phone: +1 631-791-8378)
   Notice error is shown and can't invite user.
4. Go to inbox

Expected Result:

WS chat with invalid Phone number is not created

Actual Result:

WS chat with invalid Phone number is created

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642873_1729664022785.XRecorder_23102024_085834.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849978282313703906
• Upwork Job ID: 1849978282313703906
• Last Price Increase: 2024-10-26
• Automatic offers:
• akinwale | Reviewer | 104685790

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Edited by proposal-police: This proposal was edited at 2024-10-23 10:33:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS chat is still available for failed to add workspace members.

What is the root cause of that problem?

When we invite a member, we optimistically create a report for the invited member. However, we don't clear the report when fails, we only set the isLoadingInitialReportActions metadata to false.

App/src/libs/actions/Policy/Policy.ts

Lines 1007 to 1013 in f251dbc

	workspaceMembersChats.onyxFailureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${optimisticReport.reportID}`,
	value: {
	isLoadingInitialReportActions: false,
	},
	});

Also, I see another issue. The optimistic member is added to the #announce room but never removed from the room if failed to be added. We already have a failure data that should remove the optimistic member when fails.

App/src/libs/actions/Policy/Member.ts

Lines 149 to 165 in 4f0ca94

	announceRoomMembers.onyxOptimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${announceReport?.reportID}`,
	value: {
	participants: ReportUtils.buildParticipantsFromAccountIDs(participantAccountIDs),
	pendingChatMembers,
	},
	});
	announceRoomMembers.onyxFailureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${announceReport?.reportID}`,
	value: {
	participants: announceReport?.participants ?? null,
	pendingChatMembers: announceReport?.pendingChatMembers ?? null,
	},
	});

However, participants is an object, so merging the new participants object that contains the optimistic members with the previous participants object will do nothing.

What changes do you think we should make in order to solve the problem?

We can clear the optimistic report when fails (and it's metadata).

workspaceMembersChats.onyxFailureData.push({
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${optimisticReport.reportID}`,
    value: null,
});

workspaceMembersChats.onyxFailureData.push({
    onyxMethod: Onyx.METHOD.SET,
    key: `${ONYXKEYS.COLLECTION.REPORT}${optimisticReport.reportID}`,
    value: null,
});

OR

We can show an error instead of clearing it like this:

App/src/libs/actions/IOU.ts

Lines 804 to 809 in f251dbc

	...(isNewChatReport
	? {
	errorFields: {
	createChat: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('report.genericCreateReportFailureMessage'),
	},
	}

workspaceMembersChats.onyxFailureData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${optimisticReport.reportID}`,
    value: {
        errorFields: {
            createChat: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('report.genericCreateReportFailureMessage'),
        },
    },
});

This way, the user will see an error on the chat and can manually remove it.

To fix the #announce participant issue, we need to set null to each member.

value: {
    participants: accountIDs.reduce((acc, curr) => {
        Object.assign(acc, {[curr]: null});
        return acc;
    }, {}),
    pendingChatMembers: announceReport?.pendingChatMembers ?? null,
},

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849978282313703906

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

@akinwale, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!