[HOLD for payment 2024-11-13] [$250] Desktop - Unexpected error when try to select the purpose "Chat and split"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5123689
Email or phone of affected tester (no customers): rybkina+102324fi@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch App
2. Create a new user (gmail)
3. Select the purpose "Chat and split expenses with friends"
4. Click on "Continue"
5. Verify that the "What’s your name?" modal appears
6. Enter any names
7. Click on "Continue"

Expected Result:

User should land to Concierge chat without issues.

Actual Result:

"What do you want to do today?" modal appeared again and errors appeared in Concierge chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6643819_1729723484035.chat_and_split.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850849037204397718
• Upwork Job ID: 1850849037204397718
• Last Price Increase: 2024-10-28

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Edited by proposal-police: This proposal was edited at 2024-10-26 04:12:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Unexpected error when try to select the purpose "Chat and split"

What is the root cause of that problem?

BE returns error saying

It's because we pass undefined value if the completedTaskReportAction?.reportActionID is null

App/src/libs/actions/Report.ts

Line 3427 in 8e13bcc

completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? undefined,

What changes do you think we should make in order to solve the problem?

We should pass '-1'or '0' as we're changing now from'-1'to'0'`

What alternative solutions did you explore? (Optional)

[trjExpensify]

I can repro this reliably, and dupe reported it here. Moving it on to get C+ eyes on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850849037204397718

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)