[HOLD for payment 2024-12-07] [$250] Workspace - Currency is shown empty for a workspace created in OD

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+shsb22co12112@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite
Make sure you are signed in the same account with OD and ND

1. Navigate to OD
2. Create a new workspace (Can be either collect or control)
3. Navigate to ND and open the workspace settings of the workspace that was created in OD
4. Observe the Default currency in the profile page

Expected Result:

The default currency is dispalyed

Actual Result:

The default currency is not displayed, "-" is displayed instead

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6657672_1730989092874.2024-11-07_17_09_15.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854617872012775593
• Upwork Job ID: 1854617872012775593
• Last Price Increase: 2024-11-21
• Automatic offers:
• Tony-MK | Contributor | 105019925

Issue Owner

Current Issue Owner: @lschurr / @zanyrenney

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency is shown empty for a workspace created in OD.

What is the root cause of that problem?

The policy?.outputCurrency is not found, hence the outputCurrency will be an empty string.

App/src/pages/workspace/WorkspaceProfilePage.tsx

Lines 56 to 58 in 2ef91b8

	const outputCurrency = policy?.outputCurrency ?? '';
	const currencySymbol = currencyList?.[outputCurrency]?.symbol ?? '';
	const formattedCurrency = !isEmptyObject(policy) && !isEmptyObject(currencyList) ? `${outputCurrency} - ${currencySymbol}` : '';

As a result, the formattedCurrency will be displayed as a dash.

What changes do you think we should make in order to solve the problem?

Since there are ways of finding the outputCurrency, let's get it by finding it from the personal policy or the default mileage rate currency which are equal to the policy?.outputCurrency.

const outputCurrency = policy?.outputCurrency ??
                       DistanceRequestUtils.getDefaultMileageRate(policy).currency ??
                       PolicyUtils.getPersonalPolicy()?.outputCurrency ?? ''

In case policy?.outputCurrency is not found, like in this case, we created the same condition, as above, in other places such as IOURequestStepDistance and TransactionUtils.calculateAmountForUpdatedWaypointOrRate.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854617872012775593

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[mohit6789]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency is showing empty when workspace created in OD.

What is the root cause of that problem?

Currency is showing empty because outputCurrency does not return from the policy object. Because of that formattedCurrency is displayed as '-'

const outputCurrency = policy?.outputCurrency ?? '';
const currencySymbol = currencyList?.[outputCurrency]?.symbol ?? '';
const formattedCurrency = !isEmptyObject(policy) && !isEmptyObject(currencyList) ? `${outputCurrency} - ${currencySymbol}` : '';

What changes do you think we should make in order to solve the problem?

To fix issue we need to make changes in two places.

1. In WorkspaceProfilePage.tsx Replace const outputCurrency = policy?.outputCurrency ?? ''; with const outputCurrency = policy?.outputCurrency ?? PolicyUtils.getPersonalPolicy()?.outputCurrency ?? CONST.CURRENCY.USD; as we used in other places.

const outputCurrency = policy?.outputCurrency ?? PolicyUtils.getPersonalPolicy()?.outputCurrency ?? CONST.CURRENCY.USD;

2. When user press on currency it should be selected in currency sidebar. To fix this issue we need to make changes in WorkspaceProfileCurrencyPage.tsx.

const outputCurrency = policy?.outputCurrency ?? PolicyUtils.getPersonalPolicy()?.outputCurrency ?? CONST.CURRENCY.USD;

<CurrencySelectionList
    searchInputLabel={translate('workspace.editor.currencyInputLabel')}
    onSelect={onSelectCurrency}
    initiallySelectedCurrencyCode={outputCurrency}
/>

What alternative solutions did you explore? (Optional)

NA

[lschurr]

@Ollyws could you review these proposals?

[melvin-bot]

@Ollyws, @lschurr Whoops! This issue is 2 days overdue. Let's get this updated quick!