[HOLD for payment 2024-12-05] [$250] Dupe detection - RBR is not shown when creating dupe expense with a Gmail account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #48958
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Login to an account.
2. Create a workspace
3. Open the Workspace chat
4. Submit an expense in the Workspace with a category,
5. Submit another expense in the Workspace with a the same amount and merchant in the above but with no category.

Expected Result:

RBR(red dot) is shown in LHN and also in the report because of the dupe expense.

Actual Result:

RBR(red dot) is not shown in LHN and in the report. RBR is only shown inside the expense report

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6658672_1731060429199.Screen_Recording_2024-11-08_at_4.20.15_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857074546459286027
• Upwork Job ID: 1857074546459286027
• Last Price Increase: 2024-11-21
• Automatic offers:
• ahmedGaber93 | Reviewer | 105026209

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Edited by proposal-police: This proposal was edited at 2024-11-21 13:28:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR is not shown on the report preview when money request is dupe.

What is the root cause of that problem?

The RBR doesn't show on the report preview because it only shows if the dupe detection permission is enabled. IF the account doesn't have the permission, then RBR won't show.

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 156 to 160 in 5e69bfc

	const hasErrors =
	(hasMissingSmartscanFields && !iouSettled) ||
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	ReportUtils.hasViolations(iouReportID, transactionViolations) ||
	ReportUtils.hasWarningTypeViolations(iouReportID, transactionViolations) ||

App/src/libs/TransactionUtils/index.ts

Lines 832 to 842 in 5e69bfc

	function hasWarningTypeViolation(transactionID: string, transactionViolations: OnyxCollection<TransactionViolation[]>): boolean {
	const warningTypeViolations = transactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + transactionID]?.filter(
	(violation: TransactionViolation) => violation.type === CONST.VIOLATION_TYPES.WARNING,
	);
	const hasOnlyDupeDetectionViolation = warningTypeViolations?.every((violation: TransactionViolation) => violation.name === CONST.VIOLATIONS.DUPLICATED_TRANSACTION);
	if (!Permissions.canUseDupeDetection(allBetas ?? []) && hasOnlyDupeDetectionViolation) {
	return false;
	}
	return !!warningTypeViolations && warningTypeViolations.length > 0;
	}

However, on the individual expense preview, we just checks for the amount of the duplicates violation without checking whether the permission is enabled or not, which is different form hasWarningTypeViolations.

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 147 to 149 in 5e69bfc

	const hasDuplicates = duplicates.length > 0;
	const shouldShowRBR = hasNoticeTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold) || hasDuplicates;

So, I think there are 2 issues here. In ReportPreview, we check for warning type violation. In MoneyRequestPreviewContent, we don't check for warning type violation, but we check for duplicates, ignoring the dupe detection permission.

For the RBR doesn't show for workspace chat in the LHN issue, we already have a logic to do that actually.

App/src/libs/ReportUtils.ts

Lines 6352 to 6356 in 5955bd7

	const allReports = Object.values(ReportConnection.getAllReports() ?? {}) as Report[];
	const potentialReports = allReports.filter((r) => r?.ownerAccountID === currentUserAccountID && (r?.stateNum ?? 0) <= 1 && r?.policyID === report.policyID);
	return potentialReports.some(
	(potentialReport) => hasViolations(potentialReport.reportID, transactionViolations) || hasWarningTypeViolations(potentialReport.reportID, transactionViolations),
	);

It checks all the related report and see if there are violations. However, hasWarningTypeViolations always returns false. It happens because the warningTypeViolations here is empty. Even though the dupe violation is a warning type, the showInReview is not null.

App/src/libs/TransactionUtils/index.ts

Lines 886 to 891 in 5955bd7

	function hasWarningTypeViolation(transactionID: string, transactionViolations: OnyxCollection<TransactionViolation[]>, showInReview?: boolean | null): boolean {
	const violations = transactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + transactionID];
	const warningTypeViolations =
	violations?.filter(
	(violation: TransactionViolation) => violation.type === CONST.VIOLATION_TYPES.WARNING && (showInReview === null || showInReview === (violation.showInReview ?? false)),
	) ?? [];

It's because we pass nothing to showInReview. So, undefined !== null.

App/src/libs/ReportUtils.ts

Line 6355 in 5955bd7

(potentialReport) => hasViolations(potentialReport.reportID, transactionViolations) || hasWarningTypeViolations(potentialReport.reportID, transactionViolations),

App/src/libs/ReportUtils.ts

Lines 6370 to 6372 in 5955bd7

	function hasWarningTypeViolations(reportID: string, transactionViolations: OnyxCollection<TransactionViolation[]>, shouldShowInReview?: boolean): boolean {
	const transactions = reportsTransactions[reportID] ?? [];
	return transactions.some((transaction) => TransactionUtils.hasWarningTypeViolation(transaction.transactionID, transactionViolations, shouldShowInReview));

What changes do you think we should make in order to solve the problem?

Let's use hasWarningTypeViolations in MoneyRequestPreviewContent too.

const hasWarningTypeViolations = TransactionUtils.hasWarningTypeViolation(transaction?.transactionID ?? '-1', transactionViolations);
...
const shouldShowRBR = hasNoticeTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold) || hasWarningTypeViolations;

(MoneyRequestPreviewContent also checks for hasNoticeTypeViolation but ReportPreview don't. We can add it to ReportPreview too if needed by adding it to ReportUtils, just like the others, but I don't know how to trigger notice type violation, so not sure.)

To fix the LHN RBR issue, we should first update the showInReview type by removing the null type. Then, check for undefined instead of null.

App/src/libs/TransactionUtils/index.ts

Lines 886 to 891 in 5955bd7

	function hasWarningTypeViolation(transactionID: string, transactionViolations: OnyxCollection<TransactionViolation[]>, showInReview?: boolean | null): boolean {
	const violations = transactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + transactionID];
	const warningTypeViolations =
	violations?.filter(
	(violation: TransactionViolation) => violation.type === CONST.VIOLATION_TYPES.WARNING && (showInReview === null || showInReview === (violation.showInReview ?? false)),
	) ?? [];

(or we can just pass update showInReview to be a required param but keep it nullable)

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857074546459286027

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)