[HOLD for payment 2024-12-09] [Xero] Prevent making an unnecessary API call if the value hasn't changed

[lakchote]

Version Number: v9.0.66-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): lucien+xero@expensifail.com
Logs: NA
Expensify/Expensify Issue URL: NA
Issue reported by: @mkzie2
Slack conversation (hyperlinked to channel name): NA

Action Performed:

Prerequisite: having the browser's console open

1. Connect Xero to a Workspace
2. Go to Advanced
3. Click on Map Xero Region to (or whatever name the tracking category has)
4. Select the same value already selected

Expected Result:

An API call isn't made if the value hasn't changed

Actual Result:

An API call is made even though the value hasn't changed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Video

Screen.Recording.2024-11-19.at.22.54.29.mov

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lakchote]

@mkzie2 who reported the issue, has already a draft PR here. No new proposals needed.

@mkzie2 let me know once it's available for review, so I can assign the correct C+ to the issue.

[eh2077]

I worked with @mkzie2 on #52397 as the C+.

@lakchote Maybe you can assign me on this issue and then I'll be auto assigned to review PR #53116 if @mkzie2 links this issue in the PR.

[mkzie2]

let me know once it's available for review, so I can assign the correct C+ to the issue.

@lakchote Sure.

[mkzie2]

@lakchote The PR is ready. Do I need to wait to assign a C+ here before opening the PR? Or will open and choose the assigned C+ from bot?

[lakchote]

Assigned you @eh2077 as the C+.

@mkzie2 it should assign @eh2077 once you put your PR under review.