[HOLD for payment 2025-01-15] [$250] Room - Skeleton is displayed when create offline Room in focus mode and switch to most recent

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): v9.0.72-0
Issue reported by: Applause Internal Team

Action Performed:

1. Go to Settings> Preferences> Priority mode> Focus
2. Go offline
3. Create a room
4. Go to Settings> Preferences> Priority mode> Most recent
5. Go to the room from step 3

Expected Result:

Welcome to the room message should be displayed

Actual Result:

Skeleton is displayed in chat history/ Welcome to the room message is missing

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6685648_1733432687554.Recording__4695.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866136233253542720
• Upwork Job ID: 1866136233253542720
• Last Price Increase: 2024-12-09
• Automatic offers:
• truph01 | Contributor | 105320731

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

user Your proposal will be dismissed because you did not follow the proposal template.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Skeleton is displayed in chat history/ Welcome to the room message is missing

What is the root cause of that problem?

• When we are in focus mode and switch to most recent, we call OpenApp API, so isLoading is true, and shouldShowSkeleton is displayed:

App/src/pages/home/ReportScreen.tsx

Lines 378 to 380 in 840c227

	const isLoading = isLoadingApp ?? (!reportIDFromRoute || (!isSidebarLoaded && !isInNarrowPaneModal) || PersonalDetailsUtils.isPersonalDetailsEmpty());
	const shouldShowSkeleton =

• We already we a logic to display the recent most action when the skeleton is displaying, but we don't display if it is a CREATED action because of the visual issue:

App/src/pages/home/ReportScreen.tsx

Line 746 in 840c227

!ReportActionsUtils.isActionOfType(mostRecentReportAction, CONST.REPORT.ACTIONS.TYPE.CREATED) &&

• As a result, the skeleton is displayed and the welcome message is not.

What changes do you think we should make in order to solve the problem?

• We can check whether the current report is an optimistic report via the reportMetadata.isOptimicticReport. If so, does not need to display the skeleton because there is nothing needed to be fetched with that report as mentioned in:

App/src/libs/shouldFetchReport.ts

Line 7 in 840c227

// If the report is optimistic, there's no need to fetch it. The original action should create it.

• In detail, we need to set the reportMetadata.isOptimisticReport to true when creating policy room by adding below code to here:

        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${policyReport.reportID}`,
            value: {
                isOptimisticReport: true,
            },
        },

and below code to here:

        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${policyReport.reportID}`,
            value: {
                isOptimisticReport: true,
            },
        },

• Then in report screen, update shouldShowSkeleton condition:

App/src/pages/home/ReportScreen.tsx

Line 380 in 840c227

const shouldShowSkeleton =

    const shouldShowSkeleton = !reportMetadata.isOptimisticReport && (...)

or

    const shouldShowSkeleton = (!ReportUtils.isUserCreatedPolicyRoom(report) || !reportMetadata.isOptimisticReport) && 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

@isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866136233253542720

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)