[Due for payment 2025-02-19] Prevent Self-Approval: Fix Unexpected Behavior for Historical Workspaces and Update Existing Approvers

[marcaaron]

cc @JmillsExpensify coming from our DM

While we have the ability to set "Prevent self approval" on a workspace. There are some ways in which this feature works unexpectedly in NewDot. Specifically, the following scenario is possible and should not be:

Historical workspace behavior

Problem

• User has historical workspaces with themselves already set as the approver.
• Self approval is then enabled.
• What should we do after that? They should not be able to approve their own expenses, but we need some way to "fix" the reports currently submitted to themselves.

Solution

• Create a modal that warns the user that any users who are currently approving their own reports will be removed as the manager.
• Set the approver back to the "default approver" as shown here:

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[marcaaron]

Specifically we need design help on:

Create a modal that warns the user that any users who are currently approving their own reports will be removed as the manager.