[HOLD for payment 2025-01-15] [$250] Control Upgrade Pricing Not Displayed in Local Currency

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): expensify_convert

Action Performed:

1. Log in as a user, who is onboarding from the UK.
2. Navigate to the subscription page.
3. Observe that the subscription page pricing is displayed in GBP
4. Navigate Workspace and Upgrade to Control either by enabling rules or by connecting to Accounting
   Full story link: https://fsty.io/v/hLcPr6Z8

Expected Result:

All pricing, including the "Control" upgrade pricing, should be displayed in the user's local currency

Actual Result:

The subscription page correctly displays pricing in GBP, but the "Control" upgrade pricing is incorrectly shown in USD.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866573702240708931
• Upwork Job ID: 1866573702240708931
• Last Price Increase: 2024-12-10
• Automatic offers:
• ahmedGaber93 | Reviewer | 105389816
• Tony-MK | Contributor | 105389817

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[neonbhai]

Edited by proposal-police: This proposal was edited at 2024-12-10 19:34:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Control Upgrade Pricing Not Displayed in Local Currency

What is the root cause of that problem?

The amount is hardcoded in USD here:

App/src/languages/en.ts

Lines 4275 to 4277 in d31f259

	pricing: {
	collect: '$5 ',
	amount: '$9 ',

What changes do you think we should make in order to solve the problem?

We will use the usePreferredCurrency hook to get the preferred currency. We'll
We will define the upgrade prices as a CONST and pass it to convertToShortDisplayString, as we do in other places in the app:

App/src/pages/settings/Subscription/SubscriptionSettings/index.tsx

Lines 64 to 66 in 03f19c1

	{translate('subscription.subscriptionSettings.saveUpTo', {
	amountWithCurrency: convertToShortDisplayString(possibleCostSavings, preferredCurrency),
	})}

const preferredCurrency = usePreferredCurrency();

const upgradePrice = (isCategorizing ? CONST.COLLECT_UPGRADE_PRICE : CONST.CONTROL.UPGRADE_PRICE);

...

{convertToShortDisplayString(upgradePrice, preferredCurrency)}

[Tony-MK]

Edited by proposal-police: This proposal was edited at 2024-12-10 20:38:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Control Upgrade Pricing Not Displayed in Local Currency

What is the root cause of that problem?

The problem is that we are using values from hard-coded subscription prices.

App/src/languages/en.ts

Lines 4275 to 4278 in 499079b

	pricing: {
	collect: '$5 ',
	amount: '$9 ',
	perActiveMember: 'per active member per month.',

Instead of using the prices located SUBSCRIPTION_PRICES in useSubscriptionPrice.

App/src/hooks/useSubscriptionPrice.ts

Lines 7 to 16 in 499079b

	const SUBSCRIPTION_PRICES = {
	[CONST.PAYMENT_CARD_CURRENCY.USD]: {
	[CONST.POLICY.TYPE.CORPORATE]: {
	[CONST.SUBSCRIPTION.TYPE.ANNUAL]: 900,
	[CONST.SUBSCRIPTION.TYPE.PAYPERUSE]: 1800,
	},
	[CONST.POLICY.TYPE.TEAM]: {
	[CONST.SUBSCRIPTION.TYPE.ANNUAL]: 500,
	[CONST.SUBSCRIPTION.TYPE.PAYPERUSE]: 1000,
	},

Then, we use the hard-coded values here.

App/src/pages/workspace/upgrade/UpgradeIntro.tsx

Lines 67 to 73 in 499079b

	<Text style={[styles.textNormal, styles.textSupporting]}>
	{translate(`workspace.upgrade.${feature.id}.onlyAvailableOnPlan`)}
	<Text style={[styles.textSupporting, styles.textBold]}>
	{isCategorizing ? translate(`workspace.upgrade.pricing.collect`) : translate(`workspace.upgrade.pricing.amount`)}
	</Text>
	{translate(`workspace.upgrade.pricing.perActiveMember`)}
	</Text>

What changes do you think we should make in order to solve the problem?

Let's get the subscription price by referring to SUBSCRIPTION_PRICES located in useSubscriptionPrice to get the exact cost of the plan in the user's preferred currency.

In the UpgradeIntro.tsx file, let's add code snippet below to get the subscriptionUpgradePrice.

...

let preferredCurrency = usePreferredCurrency();
preferredCurrency = SUBSCRIPTION_PRICES.includes(preferredCurrency) ? preferredCurrency : CONST.PAYMENT_CARD_CURRENCY.USD;

const subscriptionPlan = useSubscriptionPlan();
const upgradePlan = !isCategorizing || subscriptionPlan === CONST.POLICY.TYPE.CORPORATE ?
CONST.POLICY.TYPE.CORPORATE : CONST.POLICY.TYPE.TEAM

const subscriptionUpgradePrice = SUBSCRIPTION_PRICES[preferredCurrency][upgradePlan][CONST.SUBSCRIPTION.TYPE.ANNUAL]

....

Therefore, we will replace this line with something like this:

{`${convertToShortDisplayString(subscriptionUpgradePrice, preferredCurrency)} `}

This means we can discard the hard-coded prices.

Also, if the user is from the UK, we should use GBP for the wallet balance instead of the default USD.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

We can create a function, called getSubscriptionPrice, to perform the same logic shown in the main solution and return subscriptionUpgradePrice, the price of the subscription plan upgrade.

[jliexpensify]

This is a bug, Garrett mentioned we are defaulting to USD

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866573702240708931

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)