[HOLD for payment 2025-01-15] [$250] Search - Searching Long text freezes app

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.76-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Search

Action Performed:

1. Login to any account > Click on search
2. Copy the content of this file https://github.com/user-attachments/files/17331883/default.txt
3. Paste it on the search box > Search

Expected Result:

the app doesn't freeze

Actual Result:

App freezes

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6693960_1734137701973.Screen_Recording_2024-12-14_at_3.51.22_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869128296955941205
• Upwork Job ID: 1869128296955941205
• Last Price Increase: 2024-12-24
• Automatic offers:
• QichenZhu | Contributor | 105511116

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Searching Long text freezes the app

What is the root cause of that problem?

We haven't added the maxLength to the TextInput here:

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 60 in 258e2be

function SearchRouterInput(

What changes do you think we should make in order to solve the problem?

I think we can add maxLength prop here;

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 60 in 258e2be

function SearchRouterInput(

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Searching Long text freezes app

What is the root cause of that problem?

The issue where the browser shows “You can wait for it to become a response or exit” occurs because of long-running synchronous tasks that block the main thread. This causes the UI to freeze, and the browser gives a warning to the user.

1. Synchronous Heavy Operations: Searching through long text or processing large data on the main thread without async handling.
2. UI Thread Blockage: The browser cannot render updates while a heavy task is running.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we must limit the search content and show an error when the search limit is reached.

We check if the search content has exceeded the character limit, and if it has, we show an error

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 129 in 9675b9c

<FormHelpMessage

    {hasExceededSearchLimit && (
        <View>
            <Text style={[styles.textDanger, styles.mt1]}>Search text exceeds the limit of 2048 characters.</Text>
        </View>
    )}

And limit the text input using maxLength (e.g., maxLength={2048}).

App/src/components/Search/SearchRouter/SearchRouterInput.tsx

Line 93 in 9675b9c

<TextInput

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869128296955941205

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[ahmedGaber93]

I can reproduce it on staging, but not on DEV. Anyway, I also think search input should have maxLength

Let's get @Expensify/design thought about that, and what is the expected value for maxLength? And should we display error when length exceeded ?