[BZ Checklist][$250] Rules - "days" is not displayed In Max expense age page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v 9.77-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): htad26+2@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 13/iOS 18.0
App Component: Workspace Settings

Action Performed:

Prerequisite
A workspace with rules enabled

1. Navigate to workspace settings
2. Navigate to rules > Max expense age
3. Observe the end of the input field in "Max expense age"

Expected Result:

"days" is displayed at the end of the input field.

Actual Result:

"days" is not displayed at the end of the input field, which is not consistent with the behavior on other platforms

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021871267339195943980
• Upwork Job ID: 1871267339195943980
• Last Price Increase: 2024-12-23
• Automatic offers:
• linhvovan29546 | Contributor | 105454335

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Edited by proposal-police: This proposal was edited at 2024-12-19 14:32:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rules - "days" is not displayed In Max expense age page

What is the root cause of that problem?

We use InputWrapper to render the input. This component wraps BaseTextInput, which is split into two files: index.native.ts and index.ts files. However, the suffix handling logic is implemented only for non-native platforms and is missing for native platforms.
This appears to have been missed during the migration in #47409.

App/src/pages/workspace/rules/RulesMaxExpenseAgePage.tsx

Lines 73 to 78 in e42622c

	<InputWrapper
	InputComponent={TextInput}
	inputID={INPUT_IDS.MAX_EXPENSE_AGE}
	label={translate('workspace.rules.individualExpenseRules.maxAge')}
	suffixCharacter={translate('common.days')}
	suffixStyle={styles.colorMuted}

App/src/components/TextInput/BaseTextInput/index.tsx

Lines 414 to 423 in e42622c

	{!!suffixCharacter && (
	<View style={[styles.textInputSuffixWrapper, suffixContainerStyle]}>
	<Text
	tabIndex={-1}
	style={[styles.textInputSuffix, !hasLabel && styles.pv0, styles.pointerEventsNone, suffixStyle]}
	dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
	>
	{suffixCharacter}
	</Text>
	</View>

What changes do you think we should make in order to solve the problem?

Copy the suffix handling logic from index.ts to index.native.ts

POC

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-19.at.21.13.46.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[linhvovan29546]

This issue also appears on the Rules - "Random report audit" page

Detail

Before	After

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021871267339195943980

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)