[HOLD for payment 2025-01-13] Expense - Inconsistency in category and tax change system message when editing category

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1012020@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Rules and Taxes are enabled.
• There are two tax rates - A and B.
• Tax rate A belongs to Workspace and Foreign currency default.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click Advertising category.
4. Click Default tax rate.
5. Select Tax rate B.
6. Go to workspace chat.
7. Submit an expense without category.
8. Go to transaction thread.
9. Click Category and select Advertising.
10. Note that the system message starts with tax rate first, then category.
11. Click Category and select any other category.
12. Note that the system message starts with category first, then tax rate.
13. Click Category and click on the same category to unselect it.
14. Note that the system message starts with tax rate first, then category.

Expected Result:

In Step 10, 12 and 14, when setting, changing and removing category from the expense, the system message should be consistent.

Actual Result:

When setting category (step 10), the system message starts with tax rate first, then category. The messages appear in two lines.

When changing category (step 12), the system message starts with category first, then tax rate. Both messages appear in one line.

When removing category (step 14), the system message starts with tax rate first, then category. The messages appear in two lines.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701996_1735111142157.20241225_151152.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

commented in the slack thread about the PR i think is responsible - prooobs this doesn't need to be a blocker 🤔

cc @bernhardoj @MonilBhavsar in case y'all can take a look