Approvers Flow - Admin can submit expense to self if this is forbidden

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5516593
Email or phone of affected tester (no customers): fischer9966+012825aadm@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS 14.7.2 - Safari, Chrome, Desktop. iPhone 15 Pro / 18.2.1. Google Pixel 5 / Android 14
App Component: Workspace Settings

Action Performed:

1. Create Admin account with Gmail
2. Create Collect workspace, set Workflows to enabled
3. Enable Approvals in Workflows and set Admin account as Approver
4. Enable Workflows > Delay submissions and set it to Manually
5. Login to OldDot as Admin. Go to Workspace > Members
6. Enable "Prevent Self-Approval" switch
7. Login to NewDot as Admin.
8. Submit expense from the workspace
9. Click on the report that was created

Expected Result:

Admin can not submit expense to self if this is forbidden. The button is blocked.
There is a hour glass with a comment: "_Oops! Looks like you're submitting to yourself. Approving your own reports is forbidden by your policy."

Actual Result:

Admin CAN submit expense to self if this is forbidden. Button is not blocked. Admin can approve expense after Submit and get error.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6725905_1738052094873.55824-Admin-can-submit-if-forbidden.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.