[Due for payment 2025-02-25] [$250] Hybrid - Android - Expense - App crashes when submitting a distance track expense to a workspace.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.98-7
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #55459
Email or phone of affected tester (no customers): ibellicotest+256@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Money Requests

Action Performed:

1. Open the Expensify app.
2. Tap on "Reports" on the bottom of the screen.
3. Tap on the FAB and select "Create Expense"
4. Tap on "Distance" and add valid waypoints.
5. Tap on "Next"
6. Tap on the expense destination and choose Self DM.
7. Once redirected to "Reports" again, wait for the expense to appear on the list.
8. Navigate to Self DM.
9. On the options on the created expense, select "Share it with my accountant" and select any workspace.
10. Change the distance rate and submit the expense.
11. Check the app´s behaviour after this action.

Expected Result:

User should be able to submit a distance track expense to any workspace without any issue.

Actual Result:

The app crashes after creating a distance track expense and submitting it to a workspace using the "Share with my accountant" option.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6744333_1739650879233!log.txt
https://github.com/user-attachments/assets/0898e0a7-d15d-4f2f-ba2c-bbe088465fce

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891254669429387722
• Upwork Job ID: 1891254669429387722
• Last Price Increase: 2025-02-16
• Automatic offers:
• nkdengineer | Contributor | 106152809

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production has another behavior

screen-20250215-223708.mp4

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes after creating a distance track expense and submitting it to a workspace using the "Share with my accountant" option.

What is the root cause of that problem?

When we submit a distance track expense to a workspace, the optimistic receipt has source is ReceiptGeneric and the type is the number

App/src/libs/actions/IOU.ts

Line 4762 in d68deae

const trackedReceipt = validWaypoints ? {source: ReceiptGeneric as ReceiptSource, state: CONST.IOU.RECEIPT_STATE.OPEN} : receipt;

App/src/libs/actions/IOU.ts

Line 4877 in d68deae

receipt: isFileUploadable(trackedReceipt) ? trackedReceipt : undefined,

Then the app crashes when we try to get the file name here

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Lines 93 to 95 in d68deae

	let source = transactionItem?.receipt?.source ?? '';
	if (source) {
	const filename = getFileName(source);

App/src/libs/fileDownload/FileUtils.ts

Line 101 in d68deae

const fileName = url.split('/').pop()?.split('?')[0].split('#')[0] ?? '';

But why we can't reproduce this bug in production?

It comes from #49539. After the navigation refactors, when we go to Reports to Inbox, the SearchPage isn't unmounted so the app crashes immediately.

While in production, when we go to Reports to Inbox the search page is unmounted and if we go to the Reports again, the API updates the source to current distance receipt then the app doesn't crash

What changes do you think we should make in order to solve the problem?

We should add a check here to not do this logic if the source isn't string type

if (source && typeof source === 'string') {
    const filename = getFileName(source);
    const receiptURIs = getThumbnailAndImageURIs(transactionItem, null, filename);
    const isReceiptPDF = Str.isPDF(filename);
    source = tryResolveUrlFromApiRoot(isReceiptPDF && !receiptURIs.isLocalFile ? receiptURIs.thumbnail ?? '' : receiptURIs.image ?? '');
}

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Lines 93 to 95 in d68deae

	let source = transactionItem?.receipt?.source ?? '';
	if (source) {
	const filename = getFileName(source);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.