[Due for payment 2025-03-21] [$250] Private notes - After saving private notes, RHP goes to Settings instead of room details page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.0.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #56897
Email or phone of affected tester (no customers): applausetester+aefm2@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat > Room
3. Enter room name and click Create room.
4. On room chat, click on the room header.
5. Click Private details.
6. Enter anything and save it.

Expected Result:

After saving private notes, RHP will return to room details page.

Actual Result:

After saving private notes, RHP goes to Settings.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6746457_1739866986014.20250218_161919.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894127652173613831
• Upwork Job ID: 1894127652173613831
• Last Price Increase: 2025-02-24
• Automatic offers:
• nkdengineer | Contributor | 106373247

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After saving private notes, RHP goes to Settings.

What is the root cause of that problem?

We don't pass shouldGoBackToDetailsPage in this function so it will navigate to setting page here

App/src/pages/PrivateNotes/PrivateNotesEditPage.tsx

Line 99 in b504588

goBackToDetailsPage(report, backTo);

App/src/libs/ReportUtils.ts

Lines 4682 to 4687 in b504588

	if (report?.reportID) {
	if (shouldGoBackToDetailsPage) {
	Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(report.reportID, backTo));
	} else {
	Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(report.reportID, backTo));
	}

What changes do you think we should make in order to solve the problem?

We should pass shouldGoBackToDetailsPage as true here

            goBackToDetailsPage(report, backTo, true);

App/src/pages/PrivateNotes/PrivateNotesEditPage.tsx

Line 99 in b504588

goBackToDetailsPage(report, backTo);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[github-actions]

⚠️ @NJ-2020 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After saving private notes, RHP goes to Settings instead of room details page

What is the root cause of that problem?

As part of #49539, we fixed the navigation to private notes list page for the very first time, we save a private note, the commit was c5ccc08:

We introduced a new variable hasNewNoteBeenAdded to check if the private note is new.

But while making this change, we updated the usage of navigateToDetailsPage to goBackToDetailsPage, This implementation caused the current bug as we want to navigate to the details page here.

What changes do you think we should make in order to solve the problem?

We should replace goBackToDetailsPage with navigateToDetailsPage, this correctly infers that we need to go to details for the very first time we save a private note

I also observed that hasNewNoteBeenAdded is being wrongly read the first time we add a note:

App/src/pages/PrivateNotes/PrivateNotesEditPage.tsx

Line 97 in b504588

const hasNewNoteBeenAdded = !originalNote && editedNote;

We should check for editedNote as !!editedNote, as for the first time, we store the value of the note as editedNote with the current implementation.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a navigation bug

What alternative solutions did you explore? (Optional)

[melvin-bot]

@slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twilight2294]

@slafortune can you make this one external please

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894127652173613831