[Due for payment 2025-03-11] [$250] Track expense-Track options are not auto-removed from report details RHP after adding to report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.7-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5659739
Email or phone of affected tester (no customers): applausetester+270205kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.expensify.com
2. Create an unreported manual expense (Report field is none).
3. Go to staging.new.expensify.com
4. Go to self DM.
5. Click on the expense created in Step 2.
6. Click on the report header.
7. Go back to staging.expensify.com and open the expense created in Step 2.
8. Add a report to the expense.
9. Go back to staging.new.expensify.com.
10. Wait for the report to auto refresh.

Expected Result:

Track expense options will be removed from the report details page after the unreported expense is added to a report.

Actual Result:

"Submit it to someone" and "Categorize it" are not removed from the report details page after the unreported expense is added to a report.

When hovering over these options, there is no hover effect, but the options are still clickable.

When select "Submit it to someone" option and submit it to a user, app throws error.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6755938_1740641799823.20250227_153031.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895177564455953295
• Upwork Job ID: 1895177564455953295
• Last Price Increase: 2025-02-27

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track options in report details page don't disappear when the track expense is moved to workspace.

What is the root cause of that problem?

When we render the list of options, we already assign a key for each item.

App/src/pages/ReportDetailsPage.tsx

Lines 1013 to 1016 in 0856182

	{menuItems.map((item) => (
	<MenuItem
	key={item.key}
	title={translate(item.translationKey)}

However, the key for the track expense options are all the same and it's even the same as the Settings option key.

App/src/pages/ReportDetailsPage.tsx

Lines 445 to 492 in 0856182

	if (shouldShowMenuItem) {
	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.SETTINGS,
	translationKey: 'common.settings',
	icon: Expensicons.Gear,
	isAnonymousAction: false,
	shouldShowRightIcon: true,
	action: () => {
	Navigation.navigate(ROUTES.REPORT_SETTINGS.getRoute(report?.reportID, backTo));
	},
	});
	}
	if (isTrackExpenseReport && !isDeletedParentAction) {
	const actionReportID = getOriginalReportID(report.reportID, parentReportAction);
	const whisperAction = getTrackExpenseActionableWhisper(iouTransactionID, moneyRequestReport?.reportID);
	const actionableWhisperReportActionID = whisperAction?.reportActionID;
	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.SETTINGS,
	translationKey: 'actionableMentionTrackExpense.submit',
	icon: Expensicons.Send,
	isAnonymousAction: false,
	shouldShowRightIcon: true,
	action: () => {
	createDraftTransactionAndNavigateToParticipantSelector(iouTransactionID, actionReportID, CONST.IOU.ACTION.SUBMIT, actionableWhisperReportActionID);
	},
	});
	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.SETTINGS,
	translationKey: 'actionableMentionTrackExpense.categorize',
	icon: Expensicons.Folder,
	isAnonymousAction: false,
	shouldShowRightIcon: true,
	action: () => {
	createDraftTransactionAndNavigateToParticipantSelector(iouTransactionID, actionReportID, CONST.IOU.ACTION.CATEGORIZE, actionableWhisperReportActionID);
	},
	});
	items.push({
	key: CONST.REPORT_DETAILS_MENU_ITEM.SETTINGS,
	translationKey: 'actionableMentionTrackExpense.share',
	icon: Expensicons.UserPlus,
	isAnonymousAction: false,
	shouldShowRightIcon: true,
	action: () => {
	createDraftTransactionAndNavigateToParticipantSelector(iouTransactionID, actionReportID, CONST.IOU.ACTION.SHARE, actionableWhisperReportActionID);
	},
	});
	}

What changes do you think we should make in order to solve the problem?

We need to assign a unique key to each track expense option.

• submit
• categorize
• share

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I think we can test by rendering the ReportDetailsPage and pass it a self DM track report, then update the report to workspace expense report and verify the track expense options are gone.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895177564455953295

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[CortneyOfstad]

Hi @hungvu193! We have a proposal above when you have a chance — thanks!

[hungvu193]

Thanks @bernhardoj, your proposal here looks good and tests well.

Test

Screen.Recording.2025-02-28.at.09.34.58.mov

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.