[Due for payment 2025-03-21] [$250] Web - Login - Link shows /r/undefined briefly during login

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.7-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+wejmioe1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Log in.

Expected Result:

Link will not show /r/undefined during login.

Actual Result:

Link shows /r/undefined briefly during login.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6756188_1740658781439.20250227_201714.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897015092936377155
• Upwork Job ID: 1897015092936377155
• Last Price Increase: 2025-03-04
• Automatic offers:
• dominictb | Reviewer | 106390397

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Initial link after login shows /r/undefined.

What is the root cause of that problem?

The reportID value here is undefined when we login.

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Lines 31 to 40 in 7d0bcb4

	const [initialReportID] = useState(() => {
	const currentURL = getCurrentUrl();
	const reportIdFromPath = currentURL && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);
	if (reportIdFromPath) {
	return reportIdFromPath;
	}
	const initialReport = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID);
	return initialReport?.reportID;
	});

And we use it as the param.

App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx

Lines 56 to 58 in 7d0bcb4

	<Split.Screen
	name={SCREENS.REPORT}
	initialParams={{reportID: initialReportID, openOnAdminRoom: shouldOpenOnAdminRoom() ? true : undefined}}

What changes do you think we should make in order to solve the problem?

We need to default the value to empty string. It's most likely we don't default it because of the lint, but we need to default it in this case, so we can disable the lint here.

return initialReport?.reportID ?? '';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897015092936377155

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[dominictb]

@bernhardoj I remembered we had crash issues when an Onyx's collection key ID changes from an initial empty string to an actual value. Did you verify your solution against that?

[dominictb]

Don't worry as we already have this guard utility:

App/src/pages/home/ReportScreen.tsx

Line 129 in 0a19572

const reportIDFromRoute = getNonEmptyStringOnyxID(route.params?.reportID);

@bernhardoj proposal LGTM

🎀👀🎀 C+ reviewed