[Due for payment 2025-03-21] [$500][CRITICAL] NotFoundPage when clicking camera button in the `Create expense` flow

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.6-1 (iOS 18.4)
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail: No
Email or phone of affected tester (no customers): Check thread for FS
Logs: 10min window - 14:38 UTC
Expensify/Expensify Issue URL:
Issue reported by: @ryanschaffer (on behalf of a customer).
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

1. Create expense > Scan > click button to take a picture > confirm
2. Create expense > Scan > click button to take a picture > NotFoundPage

Expected Result:

Shouldn't hit a NotFoundPage when clicking the camera button.

Actual Result:

Hitting a NotFoundPage after clicking the camera button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Shared in thread. FS here (internal).

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021896632930558877150
• Upwork Job ID: 1896632930558877150
• Last Price Increase: 2025-03-17
• Automatic offers:
• nkdengineer | Contributor | 106417556

Issue Owner

Current Issue Owner: @nkdengineer

[melvin-bot]

Triggered auto assignment to @stitesExpensify (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hitting a NotFoundPage after clicking the camera button.

What is the root cause of that problem?

If the expense report isn't loaded when we create the first expense, RequestMoney API returns the preexistingReportID report data inside the optimistic expense report.

After RequestMoney API is called, openReport API of the policy expense chat is called.

The problem appears when we handle the unused optimistic data here; oldReportID is undefined because the RequestMoney API doesn't have a reportID parameter, so the preexistingReportID value will replace all undefined parameters in the other requests. Then the OpenReport API of the policy expense chat returns code 666 and has createdChat error field.

App/src/libs/Middleware/HandleUnusedOptimisticID.ts

Line 36 in 67f43dd

const oldReportID = request.data?.reportID;

App/src/libs/Middleware/HandleUnusedOptimisticID.ts

Lines 47 to 55 in 67f43dd

	PersistedRequests.getAll().forEach((persistedRequest, index) => {
	const persistedRequestClone = clone(persistedRequest);
	persistedRequestClone.data = deepReplaceKeysAndValues(persistedRequest.data, oldReportID as string, preexistingReportID);
	PersistedRequests.update(index, persistedRequestClone);
	});
	});
	return response;
	});

And in the second time we create an expense from global flow, not found page appears because the policy expense chat of the active policy has createdChat error.

What changes do you think we should make in order to solve the problem?

Here we should get the oldReportID from the onyxData.key instead of request.data?.reportID

App/src/libs/Middleware/HandleUnusedOptimisticID.ts

Line 36 in 67f43dd

const oldReportID = request.data?.reportID;

Optional: Here we can only call deepReplaceKeysAndValues if persistedRequest.data.reportID === oldReportID

App/src/libs/Middleware/HandleUnusedOptimisticID.ts

Line 49 in 67f43dd

persistedRequestClone.data = deepReplaceKeysAndValues(persistedRequest.data, oldReportID as string, preexistingReportID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add test for handleUnusedOptimisticID in MiddlewareTest with the case above.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.