[Due for payment 2025-04-16] [$250] Worksapce - Thread title and system message for currency change have different format

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Overview.
3. Click Default currency.
4. Select a different currency.
5. Go to #admins.
6. Right click on the currency change system message > Reply in thread.

Expected Result:

Thread title will have the same format as the system message - updated the default currency to USD (previously MYR).

Actual Result:

Thread title is "updated the default currency from MYR - RM to USD - $".
System message is "updated the default currency to USD (previously MYR)".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6760566_1741062820464.20250304_122637.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897741393952717946
• Upwork Job ID: 1897741393952717946
• Last Price Increase: 2025-03-06
• Automatic offers:
• etCoderDysto | Contributor | 106432396

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-04 10:24:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread title and system message for currency change have different format

What is the root cause of that problem?

We call getReportName -> getReportNameInternal to get report header title

App/src/pages/home/HeaderView.tsx

Line 134 in b649380

const title = getReportName(reportHeaderData, policy, parentReportAction, personalDetails, invoiceReceiverPolicy);

And we are not handling currency change action type in getReportNameInternal. And since we are not handling that case, currency change action is handled by getAdminRoomInvitedParticipants - a function that returns report title for a participant invite action. And getAdminRoomInvitedParticipants doesn't format the currency change action as the chat history.

App/src/libs/ReportUtils.ts

Line 4473 in fc643d5

return getAdminRoomInvitedParticipants(parentReportAction, reportActionMessage);

What changes do you think we should make in order to solve the problem?

We should handle currency change action before the above code block preferably here. And format the message using getWorkspaceCurrencyUpdateMessage

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_CURRENCY) {
        return getWorkspaceCurrencyUpdateMessage(parentReportAction);
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test for getReportName covering a report action type of workspace currency update here. We will put an assertion that getReportName returns the expected message format when the action type is workspace currency update.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897741393952717946

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)