[REVIEW TESTS] [Due for payment 2025-04-14] [$500] Update duplicate detection to be treated as any other violation (i.e. on hold applied)

[pecanoro]

Part of the project

Main issue: https://github.com/Expensify/Expensify/issues/463946

Feature Description

Duplicate detection is more in line with our RTER Violation pattern (like the pending receipt match violation) than our full Hold pattern. Let's update duplicate detections to be treated more like the warning so that when the approver approves a report with potential duplicates, we won't show the hold modal. To do so, we'll:

• Stop putting the expenses on HOLD and showing that modal.
• Update potential duplicates to be RTER Violations (or any other warning violation) instead, simply stopping the expenses from being harvested, but not stopping them from being manually submitted or approved.
• Show a different message/next step at the top of the expense/report:
• Update the report's next steps, mirroring the pending receipt pattern:
  "Potential duplicate expenses identified. Review duplicates to enable submission."
• No change for the expense next steps
• No change to the RBR, it'll still show as the RTER Violation

Manual Test Steps

Once these updates are implemented, you should be able to run these steps and verify the expected outcomes:

1. As the submitter, create an expense for $10 with the date of today and ‘Home Depot’ as the merchant
2. As the submitter, create another expense for $10 with the date of today and ‘Home Depot’ as the merchant

• Verify that you see RBR on the workspace chat
• Verify that you see RBR on the report preview in the workspace chat
• Verify that you see RBR on each expense in the report
• Verify the next steps in the report header read: “Potential duplicate expenses identified. Review duplicates to enable submission.”

3. As the submitter, create another expense for $5.
4. As the submitter, submit the report manually
5. As the approver, access the report and click ‘Approve’

• Verify that you’re presented with a modal asking whether you want to Approve only compliant expenses, or approve the entire report.
• Verify that the options show for the entire report ($25) and one for only the expense without violations ($5).

cc/ @garrettmknight

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021898088991592917027
• Upwork Job ID: 1898088991592917027
• Last Price Increase: 2025-03-10
• Automatic offers:
• DylanDylann | Reviewer | 106480966
• nkdengineer | Contributor | 106480968

Issue Owner

Current Issue Owner: @garrettmknight

[pecanoro]

Chatting with @garrettmknight about some details and some tests before opening this up with completed details

[melvin-bot]

Current assignee @garrettmknight is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021898088991592917027

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)