[$250] Company card - Device back button navigate company card page rather than add card page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935+468@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Create WS and enable company card
3. Navigate to company card and click add card
4. From add card page choose any bank and click next
5. Click app back button and notice you end up in add card page
6. Repeat step 4
7. Now click device back button and notice you end up in company card page

Expected Result:

The Device back button navigate back add card page as app back button function

Actual Result:

After choosing card device back button navigate to the main company card page rather than add card page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6763449_1741305170011.Screen_Recording_20250307_021815_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021899200224849143843
• Upwork Job ID: 1899200224849143843
• Last Price Increase: 2025-03-10

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After choosing card device back button navigate to the main company card page rather than add card page

What is the root cause of that problem?

We are handling these steps as currentSteps in Onyx. So when we change the steps, we will not update the navigation stacks.

App/src/pages/workspace/companyCards/addNew/AddNewCardPage.tsx

Lines 20 to 21 in eaddb5d

	const [addNewCardFeed] = useOnyx(ONYXKEYS.ADD_NEW_COMPANY_CARD);
	const {currentStep} = addNewCardFeed ?? {};

App/src/pages/workspace/companyCards/addNew/AddNewCardPage.tsx

Lines 36 to 55 in eaddb5d

	switch (currentStep) {
	case CONST.COMPANY_CARDS.STEP.SELECT_BANK:
	return <SelectBankStep />;
	case CONST.COMPANY_CARDS.STEP.SELECT_FEED_TYPE:
	return <SelectFeedType />;
	case CONST.COMPANY_CARDS.STEP.CARD_TYPE:
	return <CardTypeStep />;
	case CONST.COMPANY_CARDS.STEP.BANK_CONNECTION:
	return <BankConnection policyID={policyID} />;
	case CONST.COMPANY_CARDS.STEP.CARD_INSTRUCTIONS:
	return <CardInstructionsStep policyID={policyID} />;
	case CONST.COMPANY_CARDS.STEP.CARD_NAME:
	return <CardNameStep />;
	case CONST.COMPANY_CARDS.STEP.CARD_DETAILS:
	return <DetailsStep policyID={policyID} />;
	case CONST.COMPANY_CARDS.STEP.AMEX_CUSTOM_FEED:
	return <AmexCustomFeed />;
	default:
	return <SelectBankStep />;
	}

What changes do you think we should make in order to solve the problem?

1. We should add 1 more param to the WORKSPACE_COMPANY_CARDS_ADD_NEW route like currentStep

2. We also need to update the submit functions from step to step to add the current step params.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None navigation bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

I think this might be the same as - #57037 - asking

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021899200224849143843