[Due for payment 2025-04-10] [$250] Search - Suggestion list does not appear when searching with card's last four

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• User has assigned two virtual cards to themselves.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Click on the search field.
4. Type card:expensify.
5. Type card:card.
6. Note that suggestion list appears for both search queries - card:expensify and card:card.
7. Type card: and followed by the card's last four digits.

Expected Result:

The suggestion list will appear when searching with card's last four.

Actual Result:

The suggestion list does not appear when searching with card's last four.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6763667_1741329826581.20250307_144055.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021898047057933581434
• Upwork Job ID: 1898047057933581434
• Last Price Increase: 2025-03-07
• Automatic offers:
• nkdengineer | Contributor | 106499129

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-07 08:51:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The suggestion list does not appear when searching with card's last four.

What is the root cause of that problem?

We do not check with card.lastFourPAN in here

App/src/components/Search/SearchAutocompleteList.tsx

Line 375 in c7aa2c1

.filter((card) => card.bank.toLowerCase().includes(autocompleteValue.toLowerCase()) && !alreadyAutocompletedKeys.includes(getCardDescription(card.cardID).toLowerCase()))

What changes do you think we should make in order to solve the problem?

We should update this condition to use lastFourPAN

        const filteredCards = cardAutocompleteList
            .filter((card) => isCard(card) && !isCardHiddenFromSearch(card))
            .filter((card) => (card.bank.toLowerCase().includes(autocompleteValue.toLowerCase()) || card.lastFourPAN?.includes(autocompleteValue.toLowerCase())) && !alreadyAutocompletedKeys.includes(getCardDescription(card.cardID).toLowerCase()))
            .sort()
            .slice(0, 10);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We have file test with search card data here. We should add new test at this file

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021898047057933581434

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@nkdengineer Thanks for the proposal. Your RCA and solution looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkdengineer]

friendly bump @MonilBhavsar