[Due for payment 2025-03-27] Add approvals switch is locked&disabled after reenabling Workflows when Smart limit is selected

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace has Expensify Card feature.
• User has assigned a virtual card to themselves (Limit type should not be Smart limit).
• Add approvals feature is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.
3. Click on any card.
4. Click Limit type.
5. Select Smart limit and save it.
6. Go to Workflows.
7. Note that Add approvals switch is enabled and locked.
8. Go to More features.
9. Disable and reenable Workflows.
10. Go to Workflows.

Expected Result:

Add approvals switch should not be locked.

Actual Result:

Add approvals switch is disabled and locked. User will have to change the Limit type in order to unlock the switch.

In this case, the message asks to change the limit type before "disabling" approvals, when it is already disabled and locked.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6763738_1741336218611.20250307_162316.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Not repro on production

screen-20250307-111250.mp4

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-07 10:16:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add approvals switch is disabled and locked. User will have to change the Limit type in order to unlock the switch.

What is the root cause of that problem?

We don't have any logic to disable workflow button here

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Lines 175 to 187 in d414689

	{
	icon: Illustrations.Workflows,
	titleTranslationKey: 'workspace.moreFeatures.workflows.title',
	subtitleTranslationKey: 'workspace.moreFeatures.workflows.subtitle',
	isActive: policy?.areWorkflowsEnabled ?? false,
	pendingAction: policy?.pendingFields?.areWorkflowsEnabled,
	action: (isEnabled: boolean) => {
	if (!policyID) {
	return;
	}
	enablePolicyWorkflows(policyID, isEnabled);
	},
	},

What changes do you think we should make in order to solve the problem?

1. We should disbale workflow button while we have isSmartLimitEnabled

    const [cardList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}`);
    const workspaceCards = getAllCardsForWorkspace(workspaceAccountID, cardList);
    const isSmartLimitEnabled = isSmartLimitEnabledUtil(workspaceCards);

    ... 

        {
            icon: Illustrations.Workflows,
            disabled: isSmartLimitEnabled,
        },

2. And we can add disabledAction to show warning modal like we did with others, the modal content will be confirmed later.

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Lines 98 to 103 in d414689

	const onDisabledOrganizeSwitchPress = useCallback(() => {
	if (!hasAccountingConnection) {
	return;
	}
	setIsOrganizeWarningModalOpen(true);
	}, [hasAccountingConnection]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.