Incorrect error message when deleting an approved expense

[infinite-persistence]

Version Number: 2496dfa
Reproducible in staging?: Yes
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name):

Action Performed:

1. Create and submit expense from Account-A.
2. Have an admin approve that expense.
3. Make Account-A delete that expense.

Expected Result:

Should tell the user why the expense cannot be deleted, as shown in the API response. Even the API response is quite vague -- perhaps it should say "Approved expenses cannot be deleted, unless unapproved".

{
    "code": 666,
    "jsonCode": 404,
    "type": "Expensify\\Error\\Transaction\\CantReportTransactions",
    "UUID": "<redacted>",
    "message": "You do not have the permissions required to delete expenses from this report.",
    "title": "Cannot Remove Expenses",
    "data": [],
    "htmlMessage": "",
    "onyxData": [],
    "requestID": "<redacted>"
}

Actual Result:

"Unexpected error deleting this expense. Please try again later." is shown, but this statement is not true (no point retrying).

Workaround:

None. As a user, I kept re-trying to no avail.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2025.03.14.17.43--approved.mp4

[melvin-bot]

📣 @infinite-persistence! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[infinite-persistence]

Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!

Sorry. Closing this.

[melvin-bot]

📣 @infinite-persistence! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>