[Due for payment 2025-04-16] [$250] Web - Workspace switcher is reset after refreshing Account settings and returning to Inbox

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.14-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+170303kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

• Account has at least one workspace.

1. Go to staging.new.expensify.com
2. Open workspace switcher.
3. Select a workspace.
4. Go to Account settings.
5. Refresh the page.
6. Go back to Inbox.

Expected Result:

The workspace selected in Step 3 will remain selected.

Actual Result:

The workspace switcher is reset to no filter.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6773863_1742271032784.workspace_switcher.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904905938850675363
• Upwork Job ID: 1904905938850675363
• Last Price Increase: 2025-03-26
• Automatic offers:
• daledah | Contributor | 106696402

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace switcher is reset to no filter.

What is the root cause of that problem?

When the page refreshes on the /settings/profile route, the screen stack only contains SettingsSplitNavigator, and ReportsSplitNavigator is missing from the state.

After returning to the inbox, the app triggers the logic for pushing the report split navigator:

App/src/libs/Navigation/AppNavigator/createRootStackNavigator/RootStackRouter.ts

Lines 86 to 88 in 9b63465

	if (action.payload.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR) {
	return handlePushReportSplitAction(state, action, configOptions, stackRouter, setActiveWorkspaceID);
	}

Within that logic, it attempts to retrieve the policyID from the current state:

App/src/libs/Navigation/AppNavigator/createRootStackNavigator/GetStateForActionHandlers.ts

Lines 158 to 160 in 9b63465

	} else {
	policyID = getPolicyIDFromState(state as State<RootNavigatorParamList>);
	}

Since ReportsSplitNavigator isn’t present in the state after the refresh, the policyID cannot be retrieved — leading to there is no policyID param is set, in other word, the workspace switcher is reset to no filter.

What changes do you think we should make in order to solve the problem?

To fix this issue, we can store the last accessed workspace in lastAccessedWorkspacePolicyID and use it as a fallback when retrieving the policyID parameter.

1. Store the last accessed workspace:
   We update the workspace handling logic to track the last accessed workspace policy ID:
   In
   

   App/src/libs/Navigation/AppNavigator/createRootStackNavigator/RootStackRouter.ts

   Line 68 in 9b63465

   const {setActiveWorkspaceID} = useActiveWorkspace();

    const {setActiveWorkspaceID: setActiveWorkspaceIDUtils} = useActiveWorkspace();
    const setActiveWorkspaceID = (workspaceID: string | undefined) => {
        setActiveWorkspaceIDUtils?.(workspaceID);
        updateLastAccessedWorkspace(workspaceID);
    };

2. Modify logic to retrieve policyID
   We extend the logic to include lastAccessedWorkspacePolicyID as a fallback if no policyID is found in the current state:
   In:
   

   App/src/libs/Navigation/AppNavigator/createRootStackNavigator/GetStateForActionHandlers.ts

   Lines 155 to 160 in 9b63465

   	if (haveParamsPolicyID) {
   	policyID = (action.payload.params as Record<string, string | undefined>)?.policyID;
   	setActiveWorkspaceID(policyID);
   	} else {
   	policyID = getPolicyIDFromState(state as State<RootNavigatorParamList>);
   	}

    if (haveParamsPolicyID) {
        policyID = (action.payload.params as Record<string, string | undefined>)?.policyID;
        setActiveWorkspaceID(policyID);
    } else if(policyIDFromState) {        
        policyID = getPolicyIDFromState(state as State<RootNavigatorParamList>);
    }
    else{
        policyID = lastAccessedWorkspacePolicyID
        setActiveWorkspaceID(policyID);
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Start the app on the /settings/profile URL, refresh the page, then navigate to /home and verify that the correct policyID parameter is included.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Staring at LOW status for #quality. @slafortune please bump up to HIGH if you the bug falls into the criteria below. Thx

• HIGH -  UX Reliability, API Reliability and Performance issues that are part of main flows and affect a subset of users

[melvin-bot]

@slafortune Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904905938850675363