[Due for payment 2025-04-08] [$250] Transfer Balance: Go to Wallet button redirects user to home page.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.14-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Precondition: user don't have wallet enabled and logged in

1. Go to http://staging.new.expensify.com/settings/wallet/transfer-balance
2. Click Go to Wallet button

Expected Result:

User should be navigated to Wallet page

Actual Result:

User is navigated to home page or last opened page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1063.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904018584691503387
• Upwork Job ID: 1904018584691503387
• Last Price Increase: 2025-03-24

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When pressing Go to Wallet, you're navigated to home screen instead of Wallet page.

What is the root cause of that problem?

We passed the linkKey into FullPageNotFoundView of TransferBalancePage but we forgot to pass the onLinkPress props, the default onLinkPress will be called and you will be navigated to home instead.

App/src/components/BlockingViews/BlockingView.tsx

Line 95 in 9b63465

onLinkPress = () => Navigation.dismissModal(),

What changes do you think we should make in order to solve the problem?

We should add onLinkPress props to go back to wallet page in here:

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Line 154 in 9b63465

linkKey="transferAmountPage.goToWallet"

// backToRoute `ROUTES.SETTINGS_WALLET` is optional, so we can consider remove it.
onLinkPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}

We can also check other place that used linkKey and update the correct behavior of onPressLink function.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a minor navigation bug, we can ignore the test. Incase we still want the automate test, we can use the below test case:

1. Login
2. Navigate to transfer balance page (with account that don't have wallet enabled)
3. Trigger Go to Wallet button.
4. Verify that you're navigated to Wallet page (Wallet title is found).

What alternative solutions did you explore? (Optional)

1. Change the onLinkPress default props to use goBack instead.
2. Add another props call fallBackRoute for the goBack function (Optional).

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Go to Wallet" button redirects user to home page.

What is the root cause of that problem?

This works fine before because previously we use Navigation.dismissModal() as the default value for onLinkPress, and we changed the default value in this PR so it caused this issue

We didn't pass onLinkPress param to FullPageNotFoundView here:

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Lines 150 to 155 in d493554

	<FullPageNotFoundView
	shouldShow={!shouldShowTransferView}
	titleKey="notFound.pageNotFound"
	subtitleKey="transferAmountPage.notHereSubTitle"
	linkKey="transferAmountPage.goToWallet"
	>

And it will use the default value which is Navigation.goBackToHome()

App/src/components/BlockingViews/FullPageNotFoundView.tsx

Line 69 in d493554

onLinkPress = () => Navigation.goBackToHome(),

What changes do you think we should make in order to solve the problem?

Add onLinkPress and pass Navigation.dismissModal() here:

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Lines 150 to 155 in d493554

	<FullPageNotFoundView
	shouldShow={!shouldShowTransferView}
	titleKey="notFound.pageNotFound"
	subtitleKey="transferAmountPage.notHereSubTitle"
	linkKey="transferAmountPage.goToWallet"
	>

<FullPageNotFoundView
    ...
    onLinkPress={() => {
        Navigation.dismissModal()
    }}
>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I think automated test not required for this since it is a navigation bug. But if required we can create UI test to verify that it navigated to Wallet page when the "Go to Wallet" button clicked

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904018584691503387

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[RachCHopkins]

Sorry for the delay - I assumed it would be tricky to repro but it's pretty clear.