[C+ Checklist Needs Completion] [$250] Admins can't edit expenses on draft reports in NewDot

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.15-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: None
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tpalmerton
Slack conversation (hyperlinked to channel name): #convert

Action Performed:

1. Create a workspace: delayed submission enabled, approvals enabled.
2. Invite a member
3. As the member, create an expense on the workspace
4. As the admin, click into the expense report from the member's workspace chat
5. Observe all the expense fields are read-only

Expected Result:

Admins should be able to edit expenses on draft open reports, like OldDot.

Actual Result:

The admin can't edit the expenses on the draft open report on NewDot.

Workaround:

Yes, switch to OldDot.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902673284994142992
• Upwork Job ID: 1902673284994142992
• Last Price Increase: 2025-03-20
• Automatic offers:
• mkzie2 | Contributor | 106683640

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021902673284994142992

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The admin can't edit the expenses on the draft open report on NewDot.

What is the root cause of that problem?

We only allow the admin to edit the expense if the report is not a draft

App/src/libs/ReportUtils.ts

Lines 3635 to 3638 in 3addd36

	if ((isAdmin || isManager) && !isOpenExpenseReport(moneyRequestReport)) {
	return true;
	}

What changes do you think we should make in order to solve the problem?

We can remove !isOpenExpenseReport(moneyRequestReport) here.

if ((isAdmin || isManager)) { 
   return true; 
}

App/src/libs/ReportUtils.ts

Lines 3635 to 3638 in 3addd36

	if ((isAdmin || isManager) && !isOpenExpenseReport(moneyRequestReport)) {
	return true;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update the test for canEditMoneyRequest and verify that it returns true if the user is admin for all cases.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @mkzie2 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-20 12:32:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Admins can't edit expenses on draft reports in NewDot

What is the root cause of that problem?

We didn't allow admin & manager to edit the reports if the state and status is OPEN (if stateNum and statusNum are 0)

App/src/libs/ReportUtils.ts

Lines 3634 to 3637 in 3addd36

	// Admin & managers can always edit coding fields such as tag, category, billable, etc. As long as the report has a state higher than OPEN.
	if ((isAdmin || isManager) && !isOpenExpenseReport(moneyRequestReport)) {
	return true;
	}

What changes do you think we should make in order to solve the problem?

Allow admin & manager to edit the reports in all state/status for Expense Reports

    // Admin & managers can always edit coding fields such as tag, category, billable, etc.
    if ((isAdmin || isManager) && isExpenseReport(moneyRequestReport)) {
        return true;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create a unit test for canEditMoneyRequest to verify that it returns true for Expense Report with OPEN status & state (stateNumandstatusNum` = 0) for admin

What alternative solutions did you explore? (Optional)

Or If we want only the admin can edit draft open report, and keep the manager not able to edit the draft report. we can change to the following:

if ((isAdmin && isExpenseReport(moneyRequestReport)) || (isManager && !isOpenExpenseReport(moneyRequestReport))) {
    return true;
}