[Due for payment 2025-04-08] [$250] Group Chat - "Add to group" option is present when searching for team@expensify.com

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/1971082
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to NewDot with any type of account
2. Click on the FAB (big + button) and "Start Chat" option
3. Search for team@expensify.com
   account

Expected Result:

There is no option to add to a group

Actual Result:

There is option to add to a group

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6778228_1742575836479.Screen_Recording_2025-03-21_at_7.02.58_in_the_evening.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904348274391382691
• Upwork Job ID: 1904348274391382691
• Last Price Increase: 2025-03-25
• Automatic offers:
• CyberAndrii | Contributor | 106664345

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[andriivitiv]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-25 16:49:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group Chat - "Add to group" option is present when searching for team@expensify.com

What is the root cause of that problem?

We have a check here that determines whether the button should be displayed

App/src/pages/NewChatPage.tsx

Lines 262 to 264 in a3c5730

	if (!!item.isSelfDM || (item.login && excludedGroupEmails.includes(item.login))) {
	return null;
	}

The issue is that excludedGroupEmails does not include team@expensify.com email.

What changes do you think we should make in order to solve the problem?

Add team@expensify.com to this object

App/src/CONST.ts

Line 333 in a3c5730

const EMAIL = {

TEAM_EXPENSIFY_EMAIL: 'team@expensify.com',

Then add it here

App/src/CONST.ts

Line 3429 in a3c5730

EXPENSIFY_EMAILS: [

EMAIL.TEAM_EXPENSIFY_EMAIL,

so that the email is included in excludedGroupEmails

App/src/pages/NewChatPage.tsx

Line 50 in a3c5730

const excludedGroupEmails: string[] = CONST.EXPENSIFY_EMAILS.filter((value) => value !== CONST.EMAIL.CONCIERGE);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test to NewChatPageTest.tsx that will make sure no "Add to group" button is present on the team@expensify.com option.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904348274391382691

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@CyberAndrii Will you be able to implement a test for this case?

[andriivitiv]

@fedirjh Sure, I will. Updated my proposal a bit.